Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI steps in parallel #9760

Merged
merged 13 commits into from
Feb 21, 2023
Merged

Run CI steps in parallel #9760

merged 13 commits into from
Feb 21, 2023

Conversation

Rory-Powell
Copy link
Contributor

@Rory-Powell Rory-Powell commented Feb 21, 2023 •
edited
Loading

Description

  • Break up the CI job to run individual steps
    • lint
    • build
    • unit test
    • integration test
  • This allows for an easier re-run of any part of the entire ci process (e.g. a flaky test)
  • This brings down the overall CI time by about 7 minutes

Addresses:

Also see:

@Rory-Powell Rory-Powell marked this pull request as ready for review February 21, 2023 16:48
@Rory-Powell Rory-Powell changed the title [draft] Parallel ci Run CI steps in parallel Feb 21, 2023
mike12345567
mike12345567 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's beautiful, Send it!

adrinr
adrinr approved these changes Feb 21, 2023
View reviewed changes
.husky/pre-commit
@@ -1,4 +1,2 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn run lint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

packages/backend-core/tests/utilities/DBTestConfiguration.ts Outdated Show resolved Hide resolved
@Rory-Powell Rory-Powell merged commit f153fb8 into develop Feb 21, 2023
@Rory-Powell Rory-Powell deleted the parallel-ci branch February 21, 2023 17:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adrinr adrinr adrinr approved these changes

@mike12345567 mike12345567 mike12345567 approved these changes

@shogunpurple shogunpurple Awaiting requested review from shogunpurple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rory-Powell @mike12345567 @adrinr