Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle webhook errors #9715

Merged

Conversation

melohagan
Copy link
Collaborator

Description

Fix for invalid webhook URLs crashing automations page.

Addresses:

Screenshots

Screenshot 2023-02-16 at 15 58 12
Screenshot 2023-02-16 at 15 58 33

Documentation

  • I have reviewed the budibase documentatation to verify if this feature requires any changes. If changes or new docs are required I have written them.

@melohagan melohagan requested a review from PClmnt February 16, 2023 15:59
@codecov-commenter
Copy link

Codecov Report

Merging #9715 (c4b1277) into master (942965d) will decrease coverage by 0.05%.
The diff coverage is 20.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #9715      +/-   ##
==========================================
- Coverage   57.21%   57.16%   -0.05%     
==========================================
  Files         490      490              
  Lines       16159    16175      +16     
  Branches     2629     2633       +4     
==========================================
+ Hits         9245     9247       +2     
- Misses       4650     4660      +10     
- Partials     2264     2268       +4     
Impacted Files Coverage Δ
...ackages/server/src/automations/steps/integromat.ts 38.46% <0.00%> (-17.10%) ⬇️
packages/server/src/automations/steps/slack.ts 38.46% <0.00%> (-17.10%) ⬇️
packages/server/src/automations/steps/discord.ts 68.42% <40.00%> (-11.58%) ⬇️
packages/server/src/automations/steps/zapier.ts 76.92% <40.00%> (-23.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aptkingston
Copy link
Member

aptkingston commented Feb 16, 2023

I was worried that your PR to fix this might conflict with mine, as I've rewritten the majority of automation state handling here: #9714, which includes handling these failures gracefully, but having looked at the code it looks like you've added a fix to the underlying automation steps which is great too, and compliments my other work on that branch.

My PR handles any automation test failures properly which includes this and many other scenarios which bricked the builder, but improving the steps themselves is a great addition as well.

@melohagan melohagan merged commit 02ed5fd into master Feb 16, 2023
@melohagan melohagan deleted the budi-6589-invalid-slackdiscord-webhook-url-crashes branch February 16, 2023 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants