Fix issue with forms after cleanup #15332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
mike12345567
approved these changes
Jan 9, 2025
aptkingston
reviewed
Jan 9, 2025
| @@ -31,7 +31,7 @@ const getDatasourceFetchInstance = datasource => { | |||
| if (!handler) { | |||
| return null | |||
| } | |||
| return new handler({ API }) | |||
| return new handler({ API, datasource }) | |||
There was a problem hiding this comment.
This has the effect of causing the fetch to load initial data, which means any usage of fetchDatasourceSchema or fetchDatasourceDefinition (which are quite common) will cause a wasted call to the search endpoint. It's quite spammy and should definitely be fixed before releasing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing an issue introduced in #15295
We did change the way that some datafetches are consumed, assuming we always have a valid datasource within it. I skipped a usage of it, where this was not the case.
Error we got:
After the fix:
