Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect grid config in builder #15273

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Respect grid config in builder #15273

merged 3 commits into from
Dec 31, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Dec 31, 2024

Description

We found an issue with the builder, not updating order and width settings of the columns if these are not directly specified. Because of this, views without specific order or width, instead of using the default values, will use the last provided settings. This will cause inconsistency, as the same view will be displayed differently depending on the user journey.

Having the following views:

  1. Narrow columns with columns being reordered
image
  1. Default view, with no settings modified
image
  1. Wide view, with only column width being modified
image

Previously, the column order and width were not respected in view 2, and neither was the order in view 3:
https://github.com/user-attachments/assets/7cfe408c-d48e-42c8-9287-f2ab23dda5d7

After the fix:

Screen.Recording.2024-12-31.at.12.53.43.mov

Launchcontrol

Fix grid width and order behaviour when using default values

Copy link

qa-wolf bot commented Dec 31, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/xs labels Dec 31, 2024
@adrinr adrinr requested a review from aptkingston December 31, 2024 11:54
@adrinr adrinr marked this pull request as ready for review December 31, 2024 11:54
@adrinr adrinr requested a review from PClmnt December 31, 2024 12:56
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I can see that in the specific case of swapping between views in the data section then the "old column" logic would use order and size from a column in a different view. I can't fully remember why I added that in the first place, but if it's needed for something then I'm sure it'll appear again and we can add a solution for both.

@adrinr adrinr merged commit ed1c9d0 into master Dec 31, 2024
20 checks passed
@adrinr adrinr deleted the fix/respect-grid-config branch December 31, 2024 13:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants