Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc V3 improvements #14865

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Misc V3 improvements #14865

merged 3 commits into from
Oct 24, 2024

Conversation

aptkingston
Copy link
Member

Description

  • Don't send a wasted API request when changing datasource access if the value is unchanged
  • Show warning in user side panel if you haven't published your app, letting users know they'll need to publish before other people can access it

image

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Oct 24, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@aptkingston aptkingston marked this pull request as ready for review October 24, 2024 15:29
shogunpurple
shogunpurple approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aptkingston aptkingston merged commit 15336d6 into v3-ui Oct 24, 2024
11 checks passed
@aptkingston aptkingston deleted the cheeks-fixes branch October 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogunpurple shogunpurple shogunpurple approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aptkingston @shogunpurple