Calculation Views UI #14778
Merged
Calculation Views UI #14778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto view-calculation-ui
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
shogunpurple
approved these changes
Oct 24, 2024
| <InfoDisplay | ||
| icon="Help" | ||
| quiet | ||
| body="Calculations only work with numeric columns and a maximum of 5 calculations can be added at once." |
There was a problem hiding this comment.
Is this a hard technical limitation or soft limit?
There was a problem hiding this comment.
Soft limit as far as I know. This was just specified in the ticket, but I'm not sure if there's any real reason for it other than to limit the potential performance hit of running these.
|
Test failures are random flakes. Going to merge this in and let us use it in QA. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the UI for calculation views.
View type is specified upon creation. "Normal" views are called "Table" views.
Calculation views are configured using the "Configure calculations" button in the grid toolbar:
This opens the calculation editor when you can define which calculations you'd like to add to your view.
Example of calculation results:
Clarification of functionality: