Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of PostHog used in the cli package. #14633

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Sep 24, 2024

Description

This needs to always line up with what backend-core uses because cli depends on backend-core. If you don't do this, you end up getting errors like this:

➜  ~ budi hosting --init
/Users/jvcalderon/.nvm/versions/node/v20.10.0/lib/node_modules/@budibase/cli/dist/index.js:892534
    this.posthog = new import_posthog_node3.PostHog(token);
                   ^

TypeError: import_posthog_node3.PostHog is not a constructor

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/xs labels Sep 24, 2024
Copy link
Contributor

@jvcalderon jvcalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samwho samwho merged commit 0786dea into master Sep 24, 2024
12 checks passed
@samwho samwho deleted the fix-cli branch September 24, 2024 11:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants