Fixing AI test cases. #14627
Merged
Fixing AI test cases. #14627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwho
reviewed
Sep 23, 2024
Comment on lines
+132
to
+133
| // init does not appear to be called currently | ||
| // expect(llmInstance.init).toHaveBeenCalled() |
There was a problem hiding this comment.
Because forCurrentTenant is mocked, which usually calls it.
samwho
approved these changes
Sep 23, 2024
Agreed - I'd like to see this test through the new automation framework, if we must mock I think we can just mock the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title - fixing a test case which was failing in
server/src/automations/tests/openai.spec.ts