Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require a flag to be set to query PostHog for feature flags. #14607

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Require a flag to be set to query PostHog for feature flags. #14607

merged 3 commits into from
Sep 19, 2024

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Sep 19, 2024

No description provided.

@samwho samwho requested a review from a team as a code owner September 19, 2024 09:11
@samwho samwho requested review from mike12345567 and removed request for a team September 19, 2024 09:11
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/xs labels Sep 19, 2024
shogunpurple
shogunpurple approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/backend-core/src/environment.ts Outdated Show resolved Hide resolved
@samwho samwho merged commit 4db1609 into master Sep 19, 2024
12 checks passed
@samwho samwho deleted the feature-flag-flag branch September 19, 2024 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shogunpurple shogunpurple shogunpurple approved these changes

@mike12345567 mike12345567 Awaiting requested review from mike12345567 mike12345567 is a code owner automatically assigned from Budibase/backend

Assignees
No one assigned
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samwho @shogunpurple