Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role name and display name updates #14579

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Role name and display name updates #14579

merged 1 commit into from
Sep 13, 2024

Conversation

aptkingston
Copy link
Member

@aptkingston aptkingston commented Sep 13, 2024 •
edited
Loading

Description

Small update to the recent role work.

  • Don't use display name as name, since this can contain spaces and results in an illegal name being stored in the doc
  • The old UI will therefore function as it always has, and the new UI will send up role names as UUIDs (which will also create proper UUID _ids as well) and display names as the readable name
  • Restore usual names for built in roles (ADMIN, BASIC etc) rather than the new display names which again contain spaces and are only part of the new UI

@aptkingston aptkingston marked this pull request as ready for review September 13, 2024 13:27
@aptkingston aptkingston requested a review from a team as a code owner September 13, 2024 13:27
mike12345567
mike12345567 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aptkingston aptkingston merged commit b64e36c into master Sep 13, 2024
12 checks passed
@aptkingston aptkingston deleted the dont-use-role-display-names-as-names branch September 13, 2024 13:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aptkingston @mike12345567