Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic when no branch condition is met #14562

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Sep 11, 2024

Description

As I was writing a test for this I realised the behaviour wasn't exactly correct. So adding in a specific case that when no branch conditions are met we return with a status. Added a test to cover this eventuality as well.

Big delta for this because i split out the branching and looping tests from the main automation scenarios file.

@PClmnt PClmnt requested a review from a team as a code owner September 11, 2024 14:01
@PClmnt PClmnt requested review from adrinr and removed request for a team September 11, 2024 14:01
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/l labels Sep 11, 2024
@PClmnt PClmnt merged commit df54cdd into master Sep 11, 2024
12 checks passed
@PClmnt PClmnt deleted the tests/automation-branching-tests branch September 11, 2024 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants