SQL - use CTEs to avoid pagination issues with large tables #14557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fterwards - fixing issue with offset pagination applying the JSON aggregation to all rows before hand.
PClmnt
reviewed
Sep 11, 2024
PClmnt
approved these changes
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title - this updates our SQL generation to use a CTE, avoiding issues when attempting to jump to large page offsets.
This is required as the
OFFSETparameter doesn't stop the rows before the offset from being selected, this includes our JSON aggregation and therefore this can perform poorly.The CTE correctly picks out the rows that we are going to page on (including using our
WHERE EXISTSstep to filter the relationships) then selects the aggregations just for those rows.This was not initially implemented as SQS could not support it yet.