-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openapi.yamlに関してのlinterを設定 #25
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0956fea
feature: openapiのlint設定
1880d94
fix: operationIdをキャメルケースに
878aaaa
fix: yml → yamlに
d4a1270
fix: operationIdがキャメルケースでないとエラーになるように
f713f9b
fix: check_openapi_format.yamlに命名を修正
346705d
fix: npm run lint
bf68749
fix: actions
792c53e
Merge branch 'main' of https://github.com/BucketFan/Radio-Openapi int…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: OpenAPI validation | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- 'openapi.yaml' | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Lint OpenAPI | ||
run: npx @stoplight/spectral-cli lint openapi.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
extends: ['spectral:oas', 'spectral:asyncapi'] | ||
aliases: | ||
PathItem: | ||
- $.paths[*] | ||
OperationObject: | ||
- '#PathItem[get,put,post,delete,options,head,patch,trace]' | ||
rules: | ||
oas3-valid-media-example: off | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. stoplightのバグで、
というものがあり、色々試しましたが解消ができなかったのでlintをoffにしています。 対象 Issue |
||
operation-tags: error | ||
operation-id-camel-case: | ||
description: Operation IDs must be camelCase since some generators (e.g. RTK Query) don't support kebab-cases. | ||
message: 'Operation ID "{{value}}" must be camelCase since some generators (e.g. RTK Query) don''t support kebab-cases.' | ||
given: '#OperationObject' | ||
severity: error | ||
then: | ||
field: operationId | ||
function: casing | ||
functionOptions: | ||
type: camel |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spectral.yamlってファイル名だと何やってるかよくわからないので、check_openapi_format.yamlとかもうちょい直感的にわかる名前にしてほしいかもな
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f713f9b こちらにて、check_openapi_format.yamlに修正しました🙇♂️