Added "default" folder for Themes (SD Card). Same behaviour as loading custom IR files #1887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added the parameter for the default folder for selecting themes instead of always starting off at root.
Same behaviour as loading custom IR files.
Types of Changes
Minor QoL change.
Verification
Go to config -> UI Theme -> SD Card -> File explorer starts inside /Themes folder instead of at root.
User-Facing Change
Further Comments
I don't know if it was intentional or not that the parameter was left out, but I was testing out a lot of themes and had to always navigate into the themes folder that was already there when I copied the sd_files from the repo onto my SD Card. So I thought why not make it the default folder like when I load a custom IR file?
Unrelated notes: should I have created an issue first before making a pull request? It's my first time contributing on GitHub and don't want to be a bother 😬