Skip to content

Commit

Permalink
Bug 1541472 - Remove Advanced Layers, since it's disabled everywhere …
Browse files Browse the repository at this point in the history
…now. r=jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D104592
  • Loading branch information
mattwoodrow committed Feb 10, 2021
1 parent 786a565 commit ea78339
Show file tree
Hide file tree
Showing 70 changed files with 31 additions and 11,293 deletions.
1 change: 0 additions & 1 deletion dom/media/ipc/RDDParent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ mozilla::ipc::IPCResult RDDParent::RecvInitVideoBridge(
Feature::HW_COMPOSITING,
Feature::D3D11_COMPOSITING,
Feature::OPENGL_COMPOSITING,
Feature::ADVANCED_LAYERS,
Feature::DIRECT2D,
Feature::WEBGPU,
},
Expand Down
3 changes: 0 additions & 3 deletions gfx/config/gfxConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,6 @@ void gfxConfig::Inherit(EnumSet<Feature> aFeatures,
case Feature::OPENGL_COMPOSITING:
status = aDevicePrefs.oglCompositing();
break;
case Feature::ADVANCED_LAYERS:
status = aDevicePrefs.advancedLayers();
break;
case Feature::DIRECT2D:
status = aDevicePrefs.useD2D1();
break;
Expand Down
1 change: 0 additions & 1 deletion gfx/config/gfxFeature.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ namespace gfx {
_(WEBRENDER_DCOMP_PRESENT, Feature, "WebRender DirectComposition") \
_(WEBRENDER_SOFTWARE, Feature, "WebRender software fallback") \
_(OMTP, Feature, "Off Main Thread Painting") \
_(ADVANCED_LAYERS, Feature, "Advanced Layers") \
_(WEBGPU, Feature, "WebGPU") \
/* Add new entries above this comment */

Expand Down
372 changes: 0 additions & 372 deletions gfx/docs/AdvancedLayers.rst

This file was deleted.

1 change: 0 additions & 1 deletion gfx/ipc/GPUChild.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ void GPUChild::Init() {
gfxConfig::GetValue(Feature::D3D11_COMPOSITING);
devicePrefs.oglCompositing() =
gfxConfig::GetValue(Feature::OPENGL_COMPOSITING);
devicePrefs.advancedLayers() = gfxConfig::GetValue(Feature::ADVANCED_LAYERS);
devicePrefs.useD2D1() = gfxConfig::GetValue(Feature::DIRECT2D);
devicePrefs.webGPU() = gfxConfig::GetValue(Feature::WEBGPU);
devicePrefs.d3d11HwAngle() = gfxConfig::GetValue(Feature::D3D11_HW_ANGLE);
Expand Down
4 changes: 0 additions & 4 deletions gfx/ipc/GPUParent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
#include "mozilla/layers/CompositorThread.h"
#include "mozilla/layers/ImageBridgeParent.h"
#include "mozilla/layers/LayerTreeOwnerTracker.h"
#include "mozilla/layers/MemoryReportingMLGPU.h"
#include "mozilla/layers/UiCompositorControllerParent.h"
#include "mozilla/layers/VideoBridgeParent.h"
#include "mozilla/webrender/RenderThread.h"
Expand Down Expand Up @@ -136,7 +135,6 @@ bool GPUParent::Init(base::ProcessId aParentPid, const char* aParentBuildID,
gfxPlatform::InitNullMetadata();
// Ensure our Factory is initialised, mainly for gfx logging to work.
gfxPlatform::InitMoz2DLogging();
mlg::InitializeMemoryReporters();
#if defined(XP_WIN)
gfxWindowsPlatform::InitMemoryReportersForGPUProcess();
DeviceManagerDx::Init();
Expand Down Expand Up @@ -194,7 +192,6 @@ mozilla::ipc::IPCResult GPUParent::RecvInit(
gfxConfig::Inherit(Feature::D3D11_COMPOSITING,
devicePrefs.d3d11Compositing());
gfxConfig::Inherit(Feature::OPENGL_COMPOSITING, devicePrefs.oglCompositing());
gfxConfig::Inherit(Feature::ADVANCED_LAYERS, devicePrefs.advancedLayers());
gfxConfig::Inherit(Feature::DIRECT2D, devicePrefs.useD2D1());
gfxConfig::Inherit(Feature::WEBGPU, devicePrefs.webGPU());
gfxConfig::Inherit(Feature::D3D11_HW_ANGLE, devicePrefs.d3d11HwAngle());
Expand Down Expand Up @@ -426,7 +423,6 @@ static void CopyFeatureChange(Feature aFeature, Maybe<FeatureFailure>* aOut) {
mozilla::ipc::IPCResult GPUParent::RecvGetDeviceStatus(GPUDeviceData* aOut) {
CopyFeatureChange(Feature::D3D11_COMPOSITING, &aOut->d3d11Compositing());
CopyFeatureChange(Feature::OPENGL_COMPOSITING, &aOut->oglCompositing());
CopyFeatureChange(Feature::ADVANCED_LAYERS, &aOut->advancedLayers());

#if defined(XP_WIN)
if (DeviceManagerDx* dm = DeviceManagerDx::Get()) {
Expand Down
2 changes: 0 additions & 2 deletions gfx/ipc/GraphicsMessages.ipdlh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ struct DevicePrefs
FeatureStatus hwCompositing;
FeatureStatus d3d11Compositing;
FeatureStatus oglCompositing;
FeatureStatus advancedLayers;
FeatureStatus useD2D1;
FeatureStatus webGPU;
FeatureStatus d3d11HwAngle;
Expand All @@ -59,7 +58,6 @@ struct GPUDeviceData
// null.
FeatureFailure? d3d11Compositing;
FeatureFailure? oglCompositing;
FeatureFailure? advancedLayers;
D3D11DeviceStatus? gpuDevice;
FeatureFailure? webGPU;
};
Expand Down
5 changes: 0 additions & 5 deletions gfx/layers/composite/LayerManagerComposite.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ class TextureSourceProvider;
class CompositingRenderTarget;
struct FPSState;
class PaintCounter;
class LayerMLGPU;
class LayerManagerMLGPU;
class UiCompositorControllerParent;
class Layer;
struct LayerProperties;
Expand Down Expand Up @@ -126,7 +124,6 @@ class HostLayerManager : public LayerManager {
virtual void InvalidateAll() = 0;

HostLayerManager* AsHostLayerManager() override { return this; }
virtual LayerManagerMLGPU* AsLayerManagerMLGPU() { return nullptr; }

void ExtractImageCompositeNotifications(
nsTArray<ImageCompositeNotificationInfo>* aNotifications) {
Expand Down Expand Up @@ -551,8 +548,6 @@ class HostLayer {

virtual Layer* GetLayer() = 0;

virtual LayerMLGPU* AsLayerMLGPU() { return nullptr; }

virtual bool SetCompositableHost(CompositableHost*) {
// We must handle this gracefully, see bug 967824
NS_WARNING(
Expand Down
Loading

0 comments on commit ea78339

Please sign in to comment.