Bug 1318004 - Replace default bodies of special member functions with…

… = default; r=Ehsan

MozReview-Commit-ID: 33AOhtFrXS8

toolkit/components/commandlines/nsCommandLine.cpp

@@ -55,7 +55,7 @@ class nsCommandLine final : public nsICommandLineRunner
   nsCommandLine();
 
 protected:
-  ~nsCommandLine() { }
+  ~nsCommandLine() = default;
 
   typedef nsresult (*EnumerateHandlersCallback)(nsICommandLineHandler* aHandler,
 					nsICommandLine* aThis,

toolkit/components/ctypes/ctypes.cpp

@@ -50,13 +50,9 @@ NS_GENERIC_FACTORY_CONSTRUCTOR(Module)
 
 NS_IMPL_ISUPPORTS(Module, nsIXPCScriptable)
 
-Module::Module()
-{
-}
+Module::Module() = default;
 
-Module::~Module()
-{
-}
+Module::~Module() = default;
 
 #define XPC_MAP_CLASSNAME Module
 #define XPC_MAP_QUOTED_CLASSNAME "Module"

toolkit/components/filepicker/nsFileView.cpp

@@ -47,7 +47,7 @@ class nsFileResult final : public nsIAutoCompleteResult
   nsString mSearchString;
   uint16_t mSearchResult;
 private:
-  ~nsFileResult() {}
+  ~nsFileResult() = default;
 };
 
 NS_IMPL_ISUPPORTS(nsFileResult, nsIAutoCompleteResult)
@@ -179,7 +179,7 @@ NS_IMETHODIMP nsFileResult::RemoveValueAt(int32_t rowIndex, bool removeFromDb)
 
 class nsFileComplete final : public nsIAutoCompleteSearch
 {
-  ~nsFileComplete() {}
+  ~nsFileComplete() = default;
 public:
   NS_DECL_ISUPPORTS
   NS_DECL_NSIAUTOCOMPLETESEARCH

toolkit/components/find/nsFindService.cpp

@@ -22,9 +22,7 @@ nsFindService::nsFindService()
 }
 
 
-nsFindService::~nsFindService()
-{
-}
+nsFindService::~nsFindService() = default;
 
 NS_IMPL_ISUPPORTS(nsFindService, nsIFindService)
 

toolkit/components/mozintl/MozIntl.cpp

@@ -14,13 +14,9 @@ using namespace mozilla;
 
 NS_IMPL_ISUPPORTS(MozIntl, mozIMozIntl)
 
-MozIntl::MozIntl()
-{
-}
+MozIntl::MozIntl() = default;
 
-MozIntl::~MozIntl()
-{
-}
+MozIntl::~MozIntl() = default;
 
 NS_IMETHODIMP
 MozIntl::AddGetCalendarInfo(JS::Handle<JS::Value> val, JSContext* cx)

toolkit/components/parentalcontrols/nsParentalControlsServiceDefault.cpp

@@ -16,9 +16,7 @@ nsParentalControlsService::nsParentalControlsService() :
   mozilla::Unused << mEnabled;
 }
 
-nsParentalControlsService::~nsParentalControlsService()
-{
-}
+nsParentalControlsService::~nsParentalControlsService() = default;
 
 NS_IMETHODIMP
 nsParentalControlsService::GetParentalControlsEnabled(bool *aResult)

toolkit/components/perf/PerfMeasurement.cpp

@@ -25,13 +25,9 @@ NS_GENERIC_FACTORY_CONSTRUCTOR(Module)
 
 NS_IMPL_ISUPPORTS(Module, nsIXPCScriptable)
 
-Module::Module()
-{
-}
+Module::Module() = default;
 
-Module::~Module()
-{
-}
+Module::~Module() = default;
 
 #define XPC_MAP_CLASSNAME Module
 #define XPC_MAP_QUOTED_CLASSNAME "Module"

toolkit/components/places/tests/gtest/test_IHistory.cpp

@@ -51,7 +51,7 @@ new_test_uri()
 
 class VisitURIObserver final : public nsIObserver
 {
-  ~VisitURIObserver() {}
+  ~VisitURIObserver() = default;
 
 public:
   NS_DECL_ISUPPORTS
@@ -310,7 +310,7 @@ namespace test_observer_topic_dispatched_helpers {
   #define URI_VISITED_RESOLUTION_TOPIC "visited-status-resolution"
   class statusObserver final : public nsIObserver
   {
-    ~statusObserver() {}
+    ~statusObserver() = default;
 
   public:
     NS_DECL_ISUPPORTS

toolkit/components/reflect/reflect.cpp

@@ -23,13 +23,9 @@ NS_GENERIC_FACTORY_CONSTRUCTOR(Module)
 
 NS_IMPL_ISUPPORTS(Module, nsIXPCScriptable)
 
-Module::Module()
-{
-}
+Module::Module() = default;
 
-Module::~Module()
-{
-}
+Module::~Module() = default;
 
 #define XPC_MAP_CLASSNAME Module
 #define XPC_MAP_QUOTED_CLASSNAME "Module"

toolkit/components/remote/nsXRemoteService.cpp

@@ -110,9 +110,7 @@ FindExtensionParameterInCommand(const char* aParameterName,
 }
 
 
-nsXRemoteService::nsXRemoteService()
-{    
-}
+nsXRemoteService::nsXRemoteService() = default;
 
 void
 nsXRemoteService::XRemoteBaseStartup(const char *aAppName, const char *aProfileName)

toolkit/components/telemetry/Telemetry.cpp

@@ -225,7 +225,7 @@ class HangReports {
       : mHangIndices(aOther.mHangIndices)
       , mAnnotations(Move(aOther.mAnnotations))
     {}
-    ~AnnotationInfo() {}
+    ~AnnotationInfo() = default;
     AnnotationInfo& operator=(AnnotationInfo&& aOther)
     {
       mHangIndices = aOther.mHangIndices;
@@ -2571,9 +2571,7 @@ RecordShutdownEndTimeStamp() {
 namespace mozilla {
 namespace Telemetry {
 
-ProcessedStack::ProcessedStack()
-{
-}
+ProcessedStack::ProcessedStack() = default;
 
 size_t ProcessedStack::GetStackSize() const
 {

toolkit/components/telemetry/TelemetryScalar.cpp

@@ -154,7 +154,7 @@ ScalarInfo::expiration() const
 class ScalarBase
 {
 public:
-  virtual ~ScalarBase() {};
+  virtual ~ScalarBase() = default;;
 
   // Set, Add and SetMaximum functions as described in the Telemetry IDL.
   virtual ScalarResult SetValue(nsIVariant* aValue) = 0;
@@ -194,7 +194,7 @@ class ScalarUnsigned : public ScalarBase
   using ScalarBase::SetValue;
 
   ScalarUnsigned() : mStorage(0) {};
-  ~ScalarUnsigned() {};
+  ~ScalarUnsigned() = default;;
 
   ScalarResult SetValue(nsIVariant* aValue) final;
   void SetValue(uint32_t aValue) final;
@@ -334,7 +334,7 @@ class ScalarString : public ScalarBase
   using ScalarBase::SetValue;
 
   ScalarString() : mStorage(EmptyString()) {};
-  ~ScalarString() {};
+  ~ScalarString() = default;;
 
   ScalarResult SetValue(nsIVariant* aValue) final;
   ScalarResult SetValue(const nsAString& aValue) final;
@@ -415,7 +415,7 @@ class ScalarBoolean : public ScalarBase
   using ScalarBase::SetValue;
 
   ScalarBoolean() : mStorage(false) {};
-  ~ScalarBoolean() {};
+  ~ScalarBoolean() = default;;
 
   ScalarResult SetValue(nsIVariant* aValue) final;
   void SetValue(bool aValue) final;
@@ -514,7 +514,7 @@ class KeyedScalar
   typedef mozilla::Pair<nsCString, nsCOMPtr<nsIVariant>> KeyValuePair;
 
   explicit KeyedScalar(uint32_t aScalarKind) : mScalarKind(aScalarKind) {};
-  ~KeyedScalar() {};
+  ~KeyedScalar() = default;;
 
   // Set, Add and SetMaximum functions as described in the Telemetry IDL.
   // These methods implicitly instantiate a Scalar[*] for each key.

toolkit/components/terminator/nsTerminator.cpp

@@ -173,10 +173,10 @@ RunWatchdog(void* arg)
 class PR_CloseDelete
 {
 public:
-  constexpr PR_CloseDelete() {}
+  constexpr PR_CloseDelete() = default;
 
   PR_CloseDelete(const PR_CloseDelete& aOther)
-  {}
+  = default;
 
   void operator()(PRFileDesc* aPtr) const
   {

toolkit/components/url-classifier/HashStore.cpp

@@ -224,8 +224,7 @@ HashStore::HashStore(const nsACString& aTableName,
 }
 
 HashStore::~HashStore()
-{
-}
+= default;
 
 nsresult
 HashStore::Reset()

toolkit/identity/IdentityCryptoService.cpp

@@ -171,7 +171,7 @@ class IdentityCryptoService final : public nsIIdentityCryptoService
   NS_DECL_THREADSAFE_ISUPPORTS
   NS_DECL_NSIIDENTITYCRYPTOSERVICE
 
-  IdentityCryptoService() { }
+  IdentityCryptoService() = default;
   nsresult Init()
   {
     nsresult rv;
@@ -183,7 +183,7 @@ class IdentityCryptoService final : public nsIIdentityCryptoService
   }
 
 private:
-  ~IdentityCryptoService() { }
+  ~IdentityCryptoService() = default;
   IdentityCryptoService(const KeyPair &) = delete;
   void operator=(const IdentityCryptoService &) = delete;
 };

toolkit/mozapps/update/updater/updater.cpp

@@ -1086,7 +1086,7 @@ class Action
 {
 public:
   Action() : mProgressCost(1), mNext(nullptr) { }
-  virtual ~Action() { }
+  virtual ~Action() = default;
 
   virtual int Parse(NS_tchar *line) = 0;
 

toolkit/system/gnome/nsGIOService.cpp

@@ -86,7 +86,7 @@ nsGIOMimeApp::Launch(const nsACString& aUri)
 
 class GIOUTF8StringEnumerator final : public nsIUTF8StringEnumerator
 {
-  ~GIOUTF8StringEnumerator() { }
+  ~GIOUTF8StringEnumerator() = default;
 
 public:
   GIOUTF8StringEnumerator() : mIndex(0) { }

toolkit/system/gnome/nsSystemAlertsService.cpp

@@ -18,11 +18,10 @@ NS_INTERFACE_MAP_BEGIN(nsSystemAlertsService)
 NS_INTERFACE_MAP_END_THREADSAFE
 
 nsSystemAlertsService::nsSystemAlertsService()
-{
-}
+= default;
 
 nsSystemAlertsService::~nsSystemAlertsService()
-{}
+= default;
 
 nsresult
 nsSystemAlertsService::Init()

toolkit/system/unixproxy/nsUnixSystemProxySettings.cpp

@@ -33,7 +33,7 @@ class nsUnixSystemProxySettings final : public nsISystemProxySettings {
   nsresult Init();
 
 private:
-  ~nsUnixSystemProxySettings() {}
+  ~nsUnixSystemProxySettings() = default;
 
   nsCOMPtr<nsIGConfService> mGConf;
   nsCOMPtr<nsIGSettingsService> mGSettings;