Skip to content

Commit

Permalink
Bug 757397 - Make test package generation quieter; r=ted
Browse files Browse the repository at this point in the history
This may reduce the size of the buildbot build logs by up to half!
  • Loading branch information
indygreg committed May 23, 2012
1 parent da070ef commit d2aa4ad
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 9 deletions.
3 changes: 3 additions & 0 deletions config/config.mk
Original file line number Diff line number Diff line change
Expand Up @@ -340,13 +340,16 @@ MAKE_JARS_FLAGS += --both-manifests
endif

TAR_CREATE_FLAGS = -cvhf
TAR_CREATE_FLAGS_QUIET = -chf

ifeq ($(OS_ARCH),BSD_OS)
TAR_CREATE_FLAGS = -cvLf
TAR_CREATE_FLAGS_QUIET = -cLf
endif

ifeq ($(OS_ARCH),OS2)
TAR_CREATE_FLAGS = -cvf
TAR_CREATE_FLAGS_QUIET = -cf
endif

#
Expand Down
3 changes: 3 additions & 0 deletions js/src/config/config.mk
Original file line number Diff line number Diff line change
Expand Up @@ -340,13 +340,16 @@ MAKE_JARS_FLAGS += --both-manifests
endif

TAR_CREATE_FLAGS = -cvhf
TAR_CREATE_FLAGS_QUIET = -chf

ifeq ($(OS_ARCH),BSD_OS)
TAR_CREATE_FLAGS = -cvLf
TAR_CREATE_FLAGS_QUIET = -cLf
endif

ifeq ($(OS_ARCH),OS2)
TAR_CREATE_FLAGS = -cvf
TAR_CREATE_FLAGS_QUIET = -cf
endif

#
Expand Down
2 changes: 1 addition & 1 deletion js/src/tests/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ PKG_STAGE = $(DIST)/test-package-stage
# stage tests for packaging
stage-package:
$(NSINSTALL) -D $(PKG_STAGE)/jsreftest/tests
@(cd $(srcdir) && tar $(TAR_CREATE_FLAGS) - $(TEST_FILES)) | (cd $(PKG_STAGE)/jsreftest/tests && tar -xf -)
(cd $(srcdir) && tar $(TAR_CREATE_FLAGS_QUIET) - $(TEST_FILES)) | (cd $(PKG_STAGE)/jsreftest/tests && tar -xf -)
$(srcdir)/jstests.py --make-manifests $(PKG_STAGE)/jsreftest/tests/

4 changes: 2 additions & 2 deletions layout/tools/reftest/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ PKG_STAGE = $(DIST)/test-package-stage
# stage harness and tests for packaging
stage-package:
$(NSINSTALL) -D $(PKG_STAGE)/reftest && $(NSINSTALL) -D $(PKG_STAGE)/reftest/tests
@(cd $(DEPTH)/_tests/reftest/ && tar $(TAR_CREATE_FLAGS) - *) | (cd $(PKG_STAGE)/reftest && tar -xf -)
(cd $(DEPTH)/_tests/reftest/ && tar $(TAR_CREATE_FLAGS_QUIET) - *) | (cd $(PKG_STAGE)/reftest && tar -xf -)
$(PYTHON) $(topsrcdir)/layout/tools/reftest/print-manifest-dirs.py \
$(topsrcdir) \
$(topsrcdir)/layout/reftests/reftest.list \
$(topsrcdir)/testing/crashtest/crashtests.list \
| (cd $(topsrcdir) && xargs tar $(TAR_CREATE_FLAGS) -) \
| (cd $(topsrcdir) && xargs tar $(TAR_CREATE_FLAGS_QUIET) -) \
| (cd $(PKG_STAGE)/reftest/tests && tar -xf -)
6 changes: 3 additions & 3 deletions testing/mochitest/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ stage-chromejar:
ifdef ACCESSIBILITY
cp -RL $(DEPTH)/_tests/testing/mochitest/a11y $(PKG_CHROMEJAR)
endif
@(cd $(PKG_STAGE)/mochitest && zip -r tests.jar content/)
(cd $(PKG_STAGE)/mochitest && zip -rq tests.jar content/)
@(rm -rf $(PKG_CHROMEJAR))

stage-package: stage-chromejar
Expand All @@ -197,8 +197,8 @@ $(_DEST_DIR):

stage-package:
$(NSINSTALL) -D $(PKG_STAGE)/mochitest && $(NSINSTALL) -D $(PKG_STAGE)/bin/plugins
@(cd $(DEPTH)/_tests/testing/mochitest/ && tar $(TAR_CREATE_FLAGS) - *) | (cd $(PKG_STAGE)/mochitest && tar -xf -)
(cd $(DEPTH)/_tests/testing/mochitest/ && tar $(TAR_CREATE_FLAGS_QUIET) - *) | (cd $(PKG_STAGE)/mochitest && tar -xf -)
@(cd $(DIST_BIN) && tar $(TAR_CREATE_FLAGS) - $(TEST_HARNESS_BINS)) | (cd $(PKG_STAGE)/bin && tar -xf -)
@(cd $(DIST_BIN)/components && tar $(TAR_CREATE_FLAGS) - $(TEST_HARNESS_COMPONENTS)) | (cd $(PKG_STAGE)/bin/components && tar -xf -)
@(cd $(topsrcdir)/build/pgo/certs && tar $(TAR_CREATE_FLAGS) - *) | (cd $(PKG_STAGE)/certs && tar -xf -)
(cd $(topsrcdir)/build/pgo/certs && tar $(TAR_CREATE_FLAGS_QUIET) - *) | (cd $(PKG_STAGE)/certs && tar -xf -)
@(cd $(DIST_BIN)/plugins && tar $(TAR_CREATE_FLAGS) - $(TEST_HARNESS_PLUGINS)) | (cd $(PKG_STAGE)/bin/plugins && tar -xf -)
4 changes: 2 additions & 2 deletions testing/testsuite-targets.mk
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ else
$(MAKE) -C $(DEPTH)/testing/mochitest stage-chromejar PKG_STAGE=$(DIST)/universal
endif
cd $(PKG_STAGE) && \
zip -r9D "$(call core_abspath,$(DIST)/$(PKG_PATH)$(TEST_PACKAGE))" *
zip -rq9D "$(call core_abspath,$(DIST)/$(PKG_PATH)$(TEST_PACKAGE))" *

ifeq (Android, $(OS_TARGET))
package-tests: stage-android
Expand Down Expand Up @@ -334,7 +334,7 @@ stage-tps: make-stage-dir
$(NSINSTALL) -D $(PKG_STAGE)/tps/tests
@(cd $(topsrcdir)/testing/tps && tar $(TAR_CREATE_FLAGS) - *) | (cd $(PKG_STAGE)/tps && tar -xf -)
@(cd $(topsrcdir)/services/sync/tps && tar $(TAR_CREATE_FLAGS) - *) | (cd $(PKG_STAGE)/tps && tar -xf -)
@(cd $(topsrcdir)/services/sync/tests/tps && tar $(TAR_CREATE_FLAGS) - *) | (cd $(PKG_STAGE)/tps/tests && tar -xf -)
(cd $(topsrcdir)/services/sync/tests/tps && tar $(TAR_CREATE_FLAGS_QUIET) - *) | (cd $(PKG_STAGE)/tps/tests && tar -xf -)

stage-mozbase: make-stage-dir
$(MAKE) -C $(DEPTH)/testing/mozbase stage-package
Expand Down
2 changes: 1 addition & 1 deletion testing/xpcshell/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@ stage-package:
@(cd $(topsrcdir)/build && tar $(TAR_CREATE_FLAGS) - $(EXTRA_BUILD_FILES)) | (cd $(PKG_STAGE)/xpcshell && tar -xf -)
@cp $(DEPTH)/mozinfo.json $(PKG_STAGE)/xpcshell
@(cd $(topsrcdir)/build/mobile && tar $(TAR_CREATE_FLAGS) - $(MOBILE_BUILD_FILES)) | (cd $(PKG_STAGE)/xpcshell && tar -xf -)
@(cd $(DEPTH)/_tests/xpcshell/ && tar $(TAR_CREATE_FLAGS) - *) | (cd $(PKG_STAGE)/xpcshell/tests && tar -xf -)
(cd $(DEPTH)/_tests/xpcshell/ && tar $(TAR_CREATE_FLAGS_QUIET) - *) | (cd $(PKG_STAGE)/xpcshell/tests && tar -xf -)
@(cd $(DIST)/bin/components && tar $(TAR_CREATE_FLAGS) - $(TEST_HARNESS_COMPONENTS)) | (cd $(PKG_STAGE)/bin/components && tar -xf -)

0 comments on commit d2aa4ad

Please sign in to comment.