Bug 1811850 - [lint] Fix ruff errors resulting from new configuration…

…, r=webdriver-reviewers,perftest-reviewers,whimboo,sparky,firefox-build-system-reviewers,ahochheiden

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D172359

js/src/gdb/mozilla/ExecutableAllocator.py

@@ -9,6 +9,7 @@
 """
 
 import gdb
+
 import mozilla.prettyprinters
 from mozilla.prettyprinters import pretty_printer, ptr_pretty_printer
 

js/src/gdb/mozilla/GCCellPtr.py

@@ -5,6 +5,7 @@
 # Pretty-printers for GCCellPtr values.
 
 import gdb
+
 import mozilla.prettyprinters
 from mozilla.prettyprinters import pretty_printer
 

js/src/gdb/mozilla/Interpreter.py

@@ -5,6 +5,7 @@
 # Pretty-printers for InterpreterRegs.
 
 import gdb
+
 import mozilla.prettyprinters as prettyprinters
 
 prettyprinters.clear_module_printers(__name__)

js/src/gdb/mozilla/IonGraph.py

@@ -17,6 +17,7 @@
 import time
 
 import gdb
+
 import mozilla.prettyprinters
 from mozilla.prettyprinters import pretty_printer
 

js/src/gdb/mozilla/JSObject.py

@@ -7,6 +7,7 @@
 import re
 
 import gdb
+
 import mozilla.prettyprinters as prettyprinters
 from mozilla.CellHeader import get_header_ptr
 from mozilla.jsval import JSValue

js/src/gdb/mozilla/JSString.py

@@ -5,6 +5,7 @@
 # Pretty-printers for SpiderMonkey strings.
 
 import gdb
+
 import mozilla.prettyprinters
 from mozilla.CellHeader import get_header_length_and_flags
 from mozilla.prettyprinters import ptr_pretty_printer

js/src/gdb/mozilla/autoload.py

@@ -8,6 +8,7 @@
 print("If they cause trouble, type: disable pretty-printer .* SpiderMonkey")
 
 import gdb.printing
+
 import mozilla.ExecutableAllocator
 
 # Import the pretty-printer modules. As a side effect, loading these

js/src/gdb/mozilla/jsop.py

@@ -6,6 +6,7 @@
 
 import gdb
 import gdb.types
+
 import mozilla.prettyprinters
 from mozilla.prettyprinters import pretty_printer, ptr_pretty_printer
 

js/src/gdb/mozilla/jsval.py

@@ -8,6 +8,7 @@
 
 import gdb
 import gdb.types
+
 import mozilla.prettyprinters
 from mozilla.prettyprinters import pretty_printer
 

js/src/gdb/mozilla/unwind.py

@@ -9,6 +9,7 @@
 import gdb
 import gdb.types
 from gdb.FrameDecorator import FrameDecorator
+
 from mozilla.JSObject import get_function_name, get_function_script
 from mozilla.prettyprinters import TypeCache
 

python/gdbpp/gdbpp/enumset.py

@@ -5,6 +5,7 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import gdb
+
 from gdbpp import GeckoPrettyPrinter
 
 

python/gdbpp/gdbpp/owningthread.py

@@ -5,6 +5,7 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import gdb
+
 from gdbpp import GeckoPrettyPrinter
 
 

python/gdbpp/gdbpp/thashtable.py

@@ -5,6 +5,7 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import gdb
+
 from gdbpp import GeckoPrettyPrinter
 
 

python/mach/mach/test/test_site.py

@@ -5,7 +5,7 @@
 import os
 from unittest import mock
 
-import pytest as pytest
+import pytest
 from buildconfig import topsrcdir
 from mozunit import main
 

python/mozbuild/.ruff.toml

@@ -3,6 +3,7 @@ src = [
     # Treat direct imports in the test modules as first party.
     "mozpack/test",
     "mozbuild/test",
+]
 
 [isort]
 known-first-party = ["mozbuild"]

python/mozbuild/mozbuild/compilation/codecomplete.py

@@ -9,6 +9,7 @@
 from mozbuild.shellutil import quote as shell_quote
 from mozbuild.shellutil import split as shell_split
 
+
 # Instropection commands.
 
 

python/mozbuild/mozbuild/configure/options.py

@@ -147,7 +147,7 @@ def __new__(cls, origin="unknown"):
         return super(NegativeOptionValue, cls).__new__(cls, origin=origin)
 
     def __init__(self, origin="unknown"):
-        return super(NegativeOptionValue, self).__init__(origin=origin)
+        super(NegativeOptionValue, self).__init__(origin=origin)
 
 
 class InvalidOptionError(Exception):

python/mozbuild/mozbuild/mach_commands.py

@@ -32,9 +32,12 @@
 from voluptuous import All, Boolean, Required, Schema
 
 import mozbuild.settings  # noqa need @SettingsProvider hook to execute
-from mozbuild.base import BinaryNotFoundException, BuildEnvironmentNotFoundException
+from mozbuild.base import (
+    BinaryNotFoundException,
+    BuildEnvironmentNotFoundException,
+    MozbuildObject,
+)
 from mozbuild.base import MachCommandConditions as conditions
-from mozbuild.base import MozbuildObject
 from mozbuild.util import MOZBUILD_METRICS_PATH
 
 here = os.path.abspath(os.path.dirname(__file__))

python/mozbuild/mozbuild/test/configure/test_checks_configure.py

@@ -8,11 +8,11 @@
 import unittest
 
 from buildconfig import topsrcdir
-from common import ConfigureTestSandbox, ensure_exe_extension, fake_short_path
 from mozpack import path as mozpath
 from mozunit import MockedOpen, main
 from six import StringIO
 
+from common import ConfigureTestSandbox, ensure_exe_extension, fake_short_path
 from mozbuild.configure import ConfigureError, ConfigureSandbox
 from mozbuild.shellutil import quote as shell_quote
 from mozbuild.util import exec_

python/mozbuild/mozbuild/test/configure/test_compile_checks.py

@@ -8,11 +8,11 @@
 
 import mozpack.path as mozpath
 from buildconfig import topsrcdir
-from common import ConfigureTestSandbox
 from mozunit import main
 from six import StringIO
 from test_toolchain_helpers import FakeCompiler
 
+from common import ConfigureTestSandbox
 from mozbuild.util import exec_
 
 

python/mozbuild/mozbuild/test/configure/test_moz_configure.py

@@ -2,9 +2,9 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-from common import BaseConfigureTest, ConfigureTestSandbox
 from mozunit import main
 
+from common import BaseConfigureTest, ConfigureTestSandbox
 from mozbuild.util import ReadOnlyNamespace, exec_, memoized_property
 
 

python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py

@@ -6,13 +6,13 @@
 import os
 
 import six
-from common import BaseConfigureTest
 from mozboot.util import MINIMUM_RUST_VERSION
 from mozpack import path as mozpath
 from mozunit import main
 from six import StringIO
 from test_toolchain_helpers import CompilerResult, FakeCompiler, PrependFlags
 
+from common import BaseConfigureTest
 from mozbuild.configure.util import Version
 from mozbuild.util import ReadOnlyNamespace, memoize
 

python/mozbuild/mozbuild/test/configure/test_toolkit_moz_configure.py

@@ -5,10 +5,10 @@
 import os
 
 from buildconfig import topsrcdir
-from common import BaseConfigureTest
 from mozpack import path as mozpath
 from mozunit import MockedOpen, main
 
+from common import BaseConfigureTest
 from mozbuild.configure.options import InvalidOptionError
 
 

python/mozbuild/mozbuild/test/configure/test_util.py

@@ -11,11 +11,11 @@
 
 import six
 from buildconfig import topsrcdir
-from common import ConfigureTestSandbox
 from mozpack import path as mozpath
 from mozunit import main
 from six import StringIO
 
+from common import ConfigureTestSandbox
 from mozbuild.configure import ConfigureSandbox
 from mozbuild.configure.util import (
     ConfigureOutputHandler,

python/mozbuild/mozbuild/util.py

@@ -430,7 +430,7 @@ def __init__(self, iterable=None, **kwargs):
             raise ValueError("List can only be created from other list instances.")
 
         self._kwargs = kwargs
-        return super(List, self).__init__(iterable)
+        super(List, self).__init__(iterable)
 
     def extend(self, l):
         if not isinstance(l, list):

python/mozbuild/mozpack/chrome/flags.py

@@ -6,9 +6,10 @@
 from collections import OrderedDict
 
 import six
-from mozpack.errors import errors
 from packaging.version import Version
 
+from mozpack.errors import errors
+
 
 class Flag(object):
     """

python/mozbuild/mozpack/chrome/manifest.py

@@ -5,11 +5,12 @@
 import os
 import re
 
-import mozpack.path as mozpath
 import six
+from six.moves.urllib.parse import urlparse
+
+import mozpack.path as mozpath
 from mozpack.chrome.flags import Flags
 from mozpack.errors import errors
-from six.moves.urllib.parse import urlparse
 
 
 class ManifestEntry(object):

python/mozbuild/mozpack/copier.py

@@ -9,8 +9,9 @@
 import sys
 from collections import Counter, OrderedDict, defaultdict
 
-import mozpack.path as mozpath
 import six
+
+import mozpack.path as mozpath
 from mozpack.errors import errors
 from mozpack.files import BaseFile, Dest
 

python/mozbuild/mozpack/files.py

@@ -18,17 +18,17 @@
 from tarfile import TarFile, TarInfo
 from tempfile import NamedTemporaryFile, mkstemp
 
-import mozpack.path as mozpath
 import six
 from jsmin import JavascriptMinify
-from mozpack.chrome.manifest import ManifestEntry, ManifestInterfaces
-from mozpack.errors import ErrorMessage, errors
-from mozpack.executables import elfhack, is_executable, may_elfhack, may_strip, strip
-from mozpack.mozjar import JarReader
 
 import mozbuild.makeutil as makeutil
+import mozpack.path as mozpath
 from mozbuild.preprocessor import Preprocessor
 from mozbuild.util import FileAvoidWrite, ensure_unicode, memoize
+from mozpack.chrome.manifest import ManifestEntry, ManifestInterfaces
+from mozpack.errors import ErrorMessage, errors
+from mozpack.executables import elfhack, is_executable, may_elfhack, may_strip, strip
+from mozpack.mozjar import JarReader
 
 try:
     import hglib

python/mozbuild/mozpack/manifests.py

@@ -5,9 +5,10 @@
 import json
 from contextlib import contextmanager
 
-import mozpack.path as mozpath
 import six
 
+import mozpack.path as mozpath
+
 from .files import (
     AbsoluteSymlinkFile,
     ExistingFile,

python/mozbuild/mozpack/mozjar.py

@@ -9,9 +9,9 @@
 from io import BytesIO, UnsupportedOperation
 from zipfile import ZIP_DEFLATED, ZIP_STORED
 
-import mozpack.path as mozpath
 import six
 
+import mozpack.path as mozpath
 from mozbuild.util import ensure_bytes
 
 JAR_STORED = ZIP_STORED

python/mozbuild/mozpack/packager/__init__.py

@@ -8,8 +8,10 @@
 import re
 from collections import deque
 
-import mozpack.path as mozpath
 import six
+
+import mozpack.path as mozpath
+from mozbuild.preprocessor import Preprocessor
 from mozpack.chrome.manifest import (
     Manifest,
     ManifestBinaryComponent,
@@ -20,8 +22,6 @@
 )
 from mozpack.errors import errors
 
-from mozbuild.preprocessor import Preprocessor
-
 
 class Component(object):
     """

python/mozbuild/mozpack/packager/formats.py

@@ -2,6 +2,8 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+from six.moves.urllib.parse import urlparse
+
 import mozpack.path as mozpath
 from mozpack.chrome.manifest import (
     Manifest,
@@ -14,7 +16,6 @@
 from mozpack.copier import FileRegistry, FileRegistrySubtree, Jarrer
 from mozpack.errors import errors
 from mozpack.files import ManifestFile
-from six.moves.urllib.parse import urlparse
 
 """
 Formatters are classes receiving packaging instructions and creating the

python/mozbuild/mozpack/packager/l10n.py

@@ -10,9 +10,10 @@
 import json
 import os
 
-import mozpack.path as mozpath
 import six
 from createprecomplete import generate_precomplete
+
+import mozpack.path as mozpath
 from mozpack.chrome.manifest import (
     Manifest,
     ManifestChrome,

python/mozbuild/mozpack/packager/unpack.py

@@ -4,6 +4,8 @@
 
 import codecs
 
+from six.moves.urllib.parse import urlparse
+
 import mozpack.path as mozpath
 from mozpack.chrome.manifest import (
     ManifestEntryWithRelPath,
@@ -16,7 +18,6 @@
 from mozpack.mozjar import JarReader
 from mozpack.packager import SimplePackager
 from mozpack.packager.formats import FlatFormatter
-from six.moves.urllib.parse import urlparse
 
 
 class UnpackFinder(BaseFinder):