Bug 1768305. Remove widget.swipe.success-threshold pref. r=hiro

Since bug 1757928 we don't vary the value. If a user were to change this value then the opacity of the swipe to nav ui element would not be in sync with the decision to navigate or not. So remove it so things can't break. The pref widget.swipe.whole-page-pixel-size should be used instead now to control sensitivity.

Differential Revision: https://phabricator.services.mozilla.com/D145828

modules/libpref/init/StaticPrefList.yaml

@@ -13319,11 +13319,6 @@
   value: 0.0000001f
   mirror: always
 
-- name: widget.swipe.success-threshold
-  type: float
-  value: 0.25f
-  mirror: always
-
 - name: widget.swipe.success-velocity-contribution
   type: float
   value: 0.05f

widget/SwipeTracker.cpp

@@ -21,6 +21,7 @@
 // These values were tweaked to make the physics feel similar to the native
 // swipe.
 static const double kSpringForce = 250.0;
+static const double kSwipeSuccessThreshold = 0.25;
 
 namespace mozilla {
 
@@ -97,8 +98,7 @@ bool SwipeTracker::ComputeSwipeSuccess() const {
   return (mGestureAmount * targetValue +
           mCurrentVelocity * targetValue *
               StaticPrefs::widget_swipe_success_velocity_contribution()) >=
-
-         StaticPrefs::widget_swipe_success_threshold();
+         kSwipeSuccessThreshold;
 }
 
 nsEventStatus SwipeTracker::ProcessEvent(const PanGestureInput& aEvent) {

widget/tests/browser/browser_test_swipe_gesture.js

@@ -137,7 +137,6 @@ add_task(async () => {
       ["browser.gesture.swipe.eight", "Browser:ForwardOrForwardDuplicate"],
       ["widget.disable-swipe-tracker", false],
       ["widget.swipe.velocity-twitch-tolerance", 0.0000001],
-      ["widget.swipe.success-threshold", 0.25],
       ["widget.swipe.success-velocity-contribution", 0.5],
     ],
   });
@@ -252,7 +251,6 @@ add_task(async () => {
       ["browser.gesture.swipe.eight", "Browser:ForwardOrForwardDuplicate"],
       ["widget.disable-swipe-tracker", false],
       ["widget.swipe.velocity-twitch-tolerance", 0.0000001],
-      ["widget.swipe.success-threshold", 0.25],
       // Set the velocity-contribution to 0 so we can exactly control the
       // values in the swipe tracker via the delta in the events that we send.
       ["widget.swipe.success-velocity-contribution", 0.0],
@@ -351,7 +349,6 @@ add_task(async () => {
       ["browser.gesture.swipe.eight", "Browser:ForwardOrForwardDuplicate"],
       ["widget.disable-swipe-tracker", false],
       ["widget.swipe.velocity-twitch-tolerance", 0.0000001],
-      ["widget.swipe.success-threshold", 0.25],
       // Set the velocity-contribution to 0 so we can exactly control the
       // values in the swipe tracker via the delta in the events that we send.
       ["widget.swipe.success-velocity-contribution", 0.0],
@@ -449,7 +446,6 @@ add_task(async () => {
       ["browser.gesture.swipe.eight", "Browser:ForwardOrForwardDuplicate"],
       ["widget.disable-swipe-tracker", false],
       ["widget.swipe.velocity-twitch-tolerance", 0.0000001],
-      ["widget.swipe.success-threshold", 0.25],
       // Set the velocity-contribution to 0 so we can exactly control the
       // values in the swipe tracker via the delta in the events that we send.
       ["widget.swipe.success-velocity-contribution", 0.0],
@@ -510,7 +506,6 @@ add_task(async () => {
       ["browser.gesture.swipe.eight", "Browser:ForwardOrForwardDuplicate"],
       ["widget.disable-swipe-tracker", false],
       ["widget.swipe.velocity-twitch-tolerance", 0.0000001],
-      ["widget.swipe.success-threshold", 0.25],
       // Set the velocity-contribution to 0 so we can exactly control the
       // values in the swipe tracker via the delta in the events that we send.
       ["widget.swipe.success-velocity-contribution", 0.0],