Bug 482942. Tests for nsILocalFile implementations. Also changes nsLo…

…calFileUnix::MoveTo to update the object to refer to the destination, matching other platforms' behaviour. r=bsmedberg
Brli · Mar 24, 2009 · b36cee1 · b36cee1
1 parent 5373165
commit b36cee1
Show file tree

Hide file tree

Showing 6 changed files with 570 additions and 469 deletions.
diff --git a/xpcom/io/nsIFile.idl b/xpcom/io/nsIFile.idl
@@ -170,6 +170,7 @@ interface nsIFile : nsISupports
      *  (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST).
      *  If 'this' is a file, and the destination file already exists, moveTo
      *  will replace the old file.
+     *  This object is updated to refer to the new file.
      *
      *  moveTo will NOT resolve aliases/shortcuts during the copy.
      *  moveTo will do the right thing and allow copies across volumes.

diff --git a/xpcom/io/nsLocalFileUnix.cpp b/xpcom/io/nsLocalFileUnix.cpp
@@ -921,6 +921,11 @@ nsLocalFile::MoveToNative(nsIFile *newParent, const nsACString &newName)
             rv = NSRESULT_FOR_ERRNO();
         }
     }
+
+    if (NS_SUCCEEDED(rv)) {
+        // Adjust this
+        mPath = newPathName;
+    }
     return rv;
 }
 

diff --git a/xpcom/tests/Makefile.in b/xpcom/tests/Makefile.in
@@ -63,7 +63,6 @@ REQUIRES	= \
 
 CPPSRCS		= \
 		nsIFileEnumerator.cpp \
-		nsIFileTest.cpp \
 		TestCallTemplates.cpp \
 		TestINIParser.cpp \
 		TestRacingServiceManager.cpp \
@@ -90,6 +89,7 @@ CPP_UNIT_TESTS = \
                  TestCOMPtr.cpp \
                  TestCOMPtrEq.cpp \
                  TestFactory.cpp \
+                 TestFile.cpp \
                  TestHashtables.cpp \
                  TestID.cpp \
                  TestObserverService.cpp \