Bug 1381253 - Remove redundant control flow declarations rs=ehsan

MozReview-Commit-ID: FFxP4aMCbOL

dom/base/CustomElementRegistry.cpp

@@ -247,8 +247,6 @@ CustomElementRegistry::RegisterUnresolvedElement(Element* aElement, nsIAtom* aTy
   nsWeakPtr* elem = unresolved->AppendElement();
   *elem = do_GetWeakReference(aElement);
   aElement->AddStates(NS_EVENT_STATE_UNRESOLVED);
-
-  return;
 }
 
 void
@@ -773,7 +771,6 @@ CustomElementRegistry::Get(JSContext* aCx, const nsAString& aName,
   }
 
   aRetVal.setObject(*data->mConstructor);
-  return;
 }
 
 already_AddRefed<Promise>

dom/base/DOMException.cpp

@@ -114,8 +114,6 @@ NSResultToNameAndMessage(nsresult aNSResult,
   }
 
   NS_WARNING("Huh, someone is throwing non-DOM errors using the DOM module!");
-
-  return;
 }
 
 nsresult

dom/base/DocumentFragment.h

@@ -113,7 +113,6 @@ class DocumentFragment : public FragmentOrElement,
   virtual void UnbindFromTree(bool aDeep, bool aNullParent) override
   {
     NS_ASSERTION(false, "Trying to unbind a fragment from a tree");
-    return;
   }
 
   virtual Element* GetNameSpaceElement() override

dom/base/Element.cpp

@@ -1305,7 +1305,6 @@ Element::SetAttribute(const nsAString& aName,
 
   aError = SetAttr(name->NamespaceID(), name->LocalName(), name->GetPrefix(),
                    aValue, true);
-  return;
 }
 
 void
@@ -2726,8 +2725,6 @@ Element::PreIdMaybeChange(int32_t aNamespaceID, nsIAtom* aName,
     return;
   }
   RemoveFromIdTable();
-
-  return;
 }
 
 void
@@ -2746,8 +2743,6 @@ Element::PostIdMaybeChange(int32_t aNamespaceID, nsIAtom* aName,
   } else {
     ClearHasID();
   }
-
-  return;
 }
 
 EventListenerManager*

dom/base/nsAttrValue.cpp

@@ -1330,7 +1330,6 @@ nsAttrValue::ParseAtomArray(const nsAString& aValue)
   }
 
   SetMiscAtomOrString(&aValue);
-  return;
 }
 
 void

dom/base/nsGlobalWindow.cpp

@@ -4900,7 +4900,6 @@ nsGlobalWindow::GetContentOuter(JSContext* aCx,
   }
 
   aRetval.set(nullptr);
-  return;
 }
 
 void

dom/canvas/WebGL2ContextQueries.cpp

@@ -208,7 +208,6 @@ WebGLContext::GetQuery(JSContext* cx, GLenum target, GLenum pname,
     }
 
     ErrorInvalidEnum("%s: Bad pname.", funcName);
-    return;
 }
 
 void

dom/canvas/WebGLTexelConversions.cpp

@@ -219,7 +219,6 @@ class WebGLImageConverter
         }
 
         mSuccess = true;
-        return;
     }
 
     template<WebGLTexelFormat SrcFormat,

dom/html/HTMLFieldSetElement.cpp

@@ -345,8 +345,6 @@ HTMLFieldSetElement::UpdateValidity(bool aElementValidity)
   if (mFieldSet) {
     mFieldSet->UpdateValidity(aElementValidity);
   }
-
-  return;
 }
 
 EventStates

dom/html/HTMLInputElement.cpp

@@ -3418,7 +3418,6 @@ HTMLInputElement::Focus(ErrorResult& aError)
     }
   }
 
-  return;
 }
 
 #if !defined(ANDROID) && !defined(XP_MACOSX)

dom/html/HTMLLinkElement.cpp

@@ -494,8 +494,6 @@ HTMLLinkElement::GetStyleSheetInfo(nsAString& aTitle,
   // If we get here we assume that we're loading a css file, so set the
   // type to 'text/css'
   aType.AssignLiteral("text/css");
-
-  return;
 }
 
 CORSMode

dom/html/nsHTMLDocument.cpp

@@ -296,10 +296,8 @@ nsHTMLDocument::TryHintCharset(nsIContentViewer* aCv,
         aCharsetSource = requestCharsetSource;
         aEncoding = WrapNotNull(requestCharset);
       }
-      return;
     }
   }
-  return;
 }
 
 
@@ -836,7 +834,6 @@ nsHTMLDocument::StopDocumentLoad()
 
   nsDocument::StopDocumentLoad();
   UnblockOnload(false);
-  return;
 }
 
 void

dom/jsurl/nsJSProtocolHandler.cpp

@@ -791,8 +791,6 @@ nsJSChannel::EvaluateScript()
     } else if (mIsAsync) {
         NotifyListener();
     }
-
-    return;
 }
 
 void

dom/media/MediaFormatReader.cpp

@@ -2533,7 +2533,6 @@ MediaFormatReader::SkipVideoDemuxToNextKeyFrame(TimeUnit aTimeThreshold)
            &MediaFormatReader::OnVideoSkipCompleted,
            &MediaFormatReader::OnVideoSkipFailed)
     ->Track(mSkipRequest);
-  return;
 }
 
 void

dom/media/MediaRecorder.cpp

@@ -1418,9 +1418,7 @@ MediaRecorder::NotifyError(nsresult aRv)
   rv = DispatchDOMEvent(nullptr, event, nullptr, nullptr);
   if (NS_FAILED(rv)) {
     NS_ERROR("Failed to dispatch the error event!!!");
-    return;
   }
-  return;
 }
 
 void

dom/media/gmp-plugin/gmp-test-output-protection.h

@@ -123,7 +123,6 @@ TestOuputProtectionAPIs()
 {
   RunOutputProtectionAPITests();
   FakeDecryptor::Message("OP tests completed");
-  return;
 }
 
 } // namespace gmptest

dom/media/mediasource/TrackBuffersManager.cpp

@@ -840,7 +840,6 @@ TrackBuffersManager::CreateDemuxerforMIMEType()
   }
 #endif
   NS_WARNING("Not supported (yet)");
-  return;
 }
 
 // We reset the demuxer by creating a new one and initializing it.

dom/media/webaudio/ScriptProcessorNode.h

@@ -103,14 +103,12 @@ class ScriptProcessorNode final : public AudioNode
     if (aChannelCount != ChannelCount()) {
       aRv.Throw(NS_ERROR_DOM_NOT_SUPPORTED_ERR);
     }
-    return;
   }
   void SetChannelCountModeValue(ChannelCountMode aMode, ErrorResult& aRv) override
   {
     if (aMode != ChannelCountMode::Explicit) {
       aRv.Throw(NS_ERROR_DOM_NOT_SUPPORTED_ERR);
     }
-    return;
   }
 
   uint32_t BufferSize() const

dom/media/webrtc/MediaEngineDefault.cpp

@@ -58,14 +58,12 @@ void
 MediaEngineDefaultVideoSource::GetName(nsAString& aName) const
 {
   aName.AssignLiteral(u"Default Video Device");
-  return;
 }
 
 void
 MediaEngineDefaultVideoSource::GetUUID(nsACString& aUUID) const
 {
   aUUID.AssignLiteral("1041FCBD-3F12-4F7B-9E9B-1EC556DD5676");
-  return;
 }
 
 uint32_t
@@ -382,14 +380,12 @@ void
 MediaEngineDefaultAudioSource::GetName(nsAString& aName) const
 {
   aName.AssignLiteral(u"Default Audio Device");
-  return;
 }
 
 void
 MediaEngineDefaultAudioSource::GetUUID(nsACString& aUUID) const
 {
   aUUID.AssignLiteral("B7CBD7C1-53EF-42F9-8353-73F61C70C092");
-  return;
 }
 
 uint32_t
@@ -533,8 +529,6 @@ MediaEngineDefault::EnumerateVideoDevices(dom::MediaSourceEnum aMediaSource,
   RefPtr<MediaEngineVideoSource> newSource = new MediaEngineDefaultVideoSource();
   mVSources.AppendElement(newSource);
   aVSources->AppendElement(newSource);
-
-  return;
 }
 
 void
@@ -559,7 +553,6 @@ MediaEngineDefault::EnumerateAudioDevices(dom::MediaSourceEnum aMediaSource,
     mASources.AppendElement(newSource);
     aASources->AppendElement(newSource);
   }
-  return;
 }
 
 } // namespace mozilla

dom/media/webrtc/MediaEngineRemoteVideoSource.cpp

@@ -61,8 +61,6 @@ MediaEngineRemoteVideoSource::Init()
   SetUUID(uniqueId);
 
   mInitDone = true;
-
-  return;
 }
 
 void
@@ -99,7 +97,6 @@ MediaEngineRemoteVideoSource::Shutdown()
 
   MOZ_ASSERT(mState == kReleased);
   mInitDone = false;
-  return;
 }
 
 nsresult

dom/media/webrtc/MediaEngineWebRTCAudio.cpp

@@ -209,14 +209,12 @@ void
 MediaEngineWebRTCMicrophoneSource::GetName(nsAString& aName) const
 {
   aName.Assign(mDeviceName);
-  return;
 }
 
 void
 MediaEngineWebRTCMicrophoneSource::GetUUID(nsACString& aUUID) const
 {
   aUUID.Assign(mDeviceUUID);
-  return;
 }
 
 // GetBestFitnessDistance returns the best distance the capture device can offer
@@ -942,7 +940,6 @@ MediaEngineWebRTCMicrophoneSource::Process(int channel,
 
   uint32_t channels = isStereo ? 2 : 1;
   InsertInGraph<int16_t>(audio10ms, length, channels);
-  return;
 }
 
 void

dom/media/webspeech/recognition/SpeechGrammar.cpp

@@ -53,14 +53,12 @@ void
 SpeechGrammar::GetSrc(nsString& aRetVal, ErrorResult& aRv) const
 {
   aRetVal = mSrc;
-  return;
 }
 
 void
 SpeechGrammar::SetSrc(const nsAString& aArg, ErrorResult& aRv)
 {
   mSrc = aArg;
-  return;
 }
 
 float
@@ -74,7 +72,6 @@ void
 SpeechGrammar::SetWeight(float aArg, ErrorResult& aRv)
 {
   aRv.Throw(NS_ERROR_NOT_IMPLEMENTED);
-  return;
 }
 
 } // namespace dom

dom/media/webspeech/recognition/SpeechGrammarList.cpp

@@ -71,7 +71,6 @@ SpeechGrammarList::AddFromURI(const nsAString& aSrc,
                               ErrorResult& aRv)
 {
   aRv.Throw(NS_ERROR_NOT_IMPLEMENTED);
-  return;
 }
 
 void
@@ -82,7 +81,6 @@ SpeechGrammarList::AddFromString(const nsAString& aString,
   SpeechGrammar* speechGrammar = new SpeechGrammar(mParent);
   speechGrammar->SetSrc(aString, aRv);
   mItems.AppendElement(speechGrammar);
-  return;
 }
 
 already_AddRefed<SpeechGrammar>