Bug 982153 - Give dynamically created script elements 1-indexed line …

…numbers. r=bz
Brli · Oct 22, 2014 · a27991b · a27991b
1 parent 7fb2ecc
commit a27991b
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/content/base/public/nsIScriptElement.h b/content/base/public/nsIScriptElement.h
@@ -28,7 +28,7 @@ class nsIScriptElement : public nsIScriptLoaderObserver {
   NS_DECLARE_STATIC_IID_ACCESSOR(NS_ISCRIPTELEMENT_IID)
 
   explicit nsIScriptElement(mozilla::dom::FromParser aFromParser)
-    : mLineNumber(0),
+    : mLineNumber(1),
       mAlreadyStarted(false),
       mMalformed(false),
       mDoneAddingChildren(aFromParser == mozilla::dom::NOT_FROM_PARSER ||

diff --git a/content/base/test/mochitest.ini b/content/base/test/mochitest.ini
@@ -556,6 +556,7 @@ skip-if = buildapp == 'mulet' || buildapp == 'b2g' || toolkit == 'android' || e1
 [test_bug922681.html]
 [test_bug927196.html]
 [test_bug945152.html]
+[test_bug982153.html]
 run-if = os == 'linux'
 [test_bug1008126.html]
 run-if = os == 'linux'

diff --git a/content/base/test/test_bug982153.html b/content/base/test/test_bug982153.html
@@ -0,0 +1,29 @@
+<!DOCTYPE HTML>
+<html>
+<!--
+https://bugzilla.mozilla.org/show_bug.cgi?id=982153
+-->
+<head>
+  <meta charset="utf-8">
+  <title>Test for Bug 982153</title>
+  <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
+  <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
+  <script>
+
+var sc = document.createElement("script");
+var error = null;
+sc.textContent = "try {\n reference_error; } catch(e) { error = e; }";
+document.documentElement.appendChild(sc);
+is(error.lineNumber, 2, "Error line number must be correct");
+
+  </script>
+</head>
+<body>
+<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=982153">Mozilla Bug 982153</a>
+<p id="display"></p>
+<div id="content" style="display: none">
+</div>
+<pre id="test">
+</pre>
+</body>
+</html>