Skip to content

Commit

Permalink
Bug 1403961, part 2 - Fix and enable eslint for ipc/. r=billm
Browse files Browse the repository at this point in the history
After the previous patch, all that is needed to pass eslint is some
whitespace fixes I generated using:
  ./mach eslint --fix ipc

The .eslintrc.js file makes eslint expect XPCShell global variables.

With those two changes, eslint can be enabled for the ipc/ directory.

MozReview-Commit-ID: BqSICp2iV6O
  • Loading branch information
amccreight committed Sep 29, 2017
1 parent e9e0b90 commit 91d6d1f
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 7 deletions.
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ extensions/universalchardet/**
gfx/**
image/**
intl/**
ipc/**
layout/**
media/**
memory/**
Expand Down
7 changes: 7 additions & 0 deletions ipc/testshell/tests/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
"use strict";

module.exports = {
"extends": [
"plugin:mozilla/xpcshell-test"
]
};
8 changes: 4 additions & 4 deletions ipc/testshell/tests/test_ipcshell.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ function run_test() {
sendCommand("runtime.processType;", callback);

[ [ "C", "D" ], [ "D", "C" ], [ "\u010C", "D" ], [ "D", "\u010C" ] ].forEach(
function (pair) {
function(pair) {
do_test_pending();
var cmp = pair[0].localeCompare(pair[1]);
sendCommand(
"'"+ pair[0] +"'.localeCompare('"+ pair[1] +"');",
function (result) {
"'" + pair[0] + "'.localeCompare('" + pair[1] + "');",
function(result) {
do_check_eq(cmp, result);
do_test_finished();
do_test_finished();
});
})
}
4 changes: 2 additions & 2 deletions ipc/testshell/tests/test_ipcshell_child.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var Cc = Components.classes;
var Ci = Components.interfaces;
var Cc = Components.classes;
var Ci = Components.interfaces;

const runtime = Cc["@mozilla.org/xre/app-info;1"].getService(Ci.nsIXULRuntime);

Expand Down

0 comments on commit 91d6d1f

Please sign in to comment.