Bug 1445942, make the backspace key a non-reserved key so that it isn…

…'t blocked by shortcut permissions, r=felipe
Brli · Dec 17, 2018 · 778c883 · 778c883
1 parent 5a1e07c
commit 778c883
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/browser/base/content/browser-sets.inc b/browser/base/content/browser-sets.inc
@@ -182,8 +182,8 @@
     <key id="key_delete" keycode="VK_DELETE" command="cmd_delete"/>
     <key id="key_selectAll" key="&selectAllCmd.key;" modifiers="accel"/>
 
-    <key keycode="VK_BACK" command="cmd_handleBackspace"/>
-    <key keycode="VK_BACK" command="cmd_handleShiftBackspace" modifiers="shift"/>
+    <key keycode="VK_BACK" command="cmd_handleBackspace" reserved="false"/>
+    <key keycode="VK_BACK" command="cmd_handleShiftBackspace" modifiers="shift" reserved="false"/>
 #ifndef XP_MACOSX
     <key id="goBackKb"  keycode="VK_LEFT" command="Browser:Back" modifiers="alt"/>
     <key id="goForwardKb"  keycode="VK_RIGHT" command="Browser:Forward" modifiers="alt"/>

diff --git a/browser/base/content/test/permissions/browser_reservedkey.js b/browser/base/content/test/permissions/browser_reservedkey.js
@@ -117,3 +117,29 @@ if (!navigator.platform.includes("Mac")) {
     BrowserTestUtils.removeTab(tab1);
   });
 }
+
+// There is a <key> element for Backspace with reserved="false", so make sure that it is not
+// treated as a blocked shortcut key.
+add_task(async function test_backspace() {
+  await new Promise(resolve => {
+    SpecialPowers.pushPrefEnv({"set": [["permissions.default.shortcuts", 2]]}, resolve);
+  });
+
+  // The input field is autofocused. If this test fails, backspace can go back
+  // in history so cancel the beforeunload event and adjust the field to make the test fail.
+  const uri = "data:text/html,<body onbeforeunload='document.getElementById('field').value = 'failed'; event.preventDefault();'>" +
+              "<input id='field' value='something' autofocus></body>";
+  let tab = await BrowserTestUtils.openNewForegroundTab(gBrowser, uri);
+
+  // Move the caret so backspace will go delete the first character.
+  EventUtils.synthesizeKey("KEY_ArrowRight", {});
+  EventUtils.synthesizeKey("KEY_Backspace", {});
+
+  let fieldValue = await ContentTask.spawn(tab.linkedBrowser, { }, async function() {
+    return content.document.getElementById("field").value;
+  });
+  is(fieldValue, "omething", "backspace not prevented");
+
+  BrowserTestUtils.removeTab(tab);
+});
+