Skip to content

Commit

Permalink
Backed out changeset af4327fd49cd (bug 1361661) for bustage in Teleme…
Browse files Browse the repository at this point in the history
…tryProcessData.h. r=backout
  • Loading branch information
Archaeopteryx committed May 22, 2017
1 parent a01f400 commit 742aad1
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 173 deletions.
3 changes: 1 addition & 2 deletions CLOBBER
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,4 @@
# changes to stick? As of bug 928195, this shouldn't be necessary! Please
# don't change CLOBBER for WebIDL changes any more.

Bug 1361661 - Update Telemetry build and headers.

Bug 1340627 - clobber for Skia update
4 changes: 0 additions & 4 deletions toolkit/components/telemetry/Processes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,12 @@
# For now this is only used to inform the data pipeline about new processes, but will be used to
# generate headers with C++ data later (enums, strings, ...).
parent:
gecko_enum: GeckoProcessType_Default
description: This is the main process. It is also known as the parent or chrome process.
content:
gecko_enum: GeckoProcessType_Content
description: This is for processes web content is rendered in.
extension:
gecko_enum: GeckoProcessType_Content
description: >
This is the WebExtension process. It is a re-used content process, with the data submitted
separately to avoid skewing other content process Telemetry.
gpu:
gecko_enum: GeckoProcessType_GPU
description: This is the compositor or GPU process.
72 changes: 0 additions & 72 deletions toolkit/components/telemetry/gen-process-data.py

This file was deleted.

66 changes: 0 additions & 66 deletions toolkit/components/telemetry/gen-process-enum.py

This file was deleted.

16 changes: 0 additions & 16 deletions toolkit/components/telemetry/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ XPIDL_MODULE = 'telemetry'
EXPORTS.mozilla += [
'!TelemetryEventEnums.h',
'!TelemetryHistogramEnums.h',
'!TelemetryProcessEnums.h',
'!TelemetryScalarEnums.h',
'ipc/TelemetryComms.h',
'ipc/TelemetryIPC.h',
Expand Down Expand Up @@ -95,8 +94,6 @@ GENERATED_FILES = [
'TelemetryEventEnums.h',
'TelemetryHistogramData.inc',
'TelemetryHistogramEnums.h',
'TelemetryProcessData.h',
'TelemetryProcessEnums.h',
'TelemetryScalarData.h',
'TelemetryScalarEnums.h',
]
Expand Down Expand Up @@ -142,18 +139,5 @@ event_enums = GENERATED_FILES['TelemetryEventEnums.h']
event_enums.script = 'gen-event-enum.py'
event_enums.inputs = event_files

# Generate data from Processes.yaml
processes_files = [
'Processes.yaml',
]

processes_enum = GENERATED_FILES['TelemetryProcessEnums.h']
processes_enum.script = 'gen-process-enum.py'
processes_enum.inputs = processes_files

processes_data = GENERATED_FILES['TelemetryProcessData.h']
processes_data.script = 'gen-process-data.py'
processes_data.inputs = processes_files

with Files('**'):
BUG_COMPONENT = ('Toolkit', 'Telemetry')
13 changes: 0 additions & 13 deletions toolkit/components/telemetry/shared_telemetry_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from __future__ import print_function

import re
import yaml

# This is a list of flags that determine which process a measurement is allowed
# to record from.
Expand Down Expand Up @@ -131,15 +130,3 @@ def add_expiration_postfix(expiration):
return expiration + "a1"

return expiration


def load_yaml_file(filename):
""" Load a YAML file from disk, throw a ParserError on failure."""
try:
with open(filename, 'r') as f:
return yaml.safe_load(f)
except IOError, e:
raise ParserError('Error opening ' + filename + ': ' + e.message)
except ValueError, e:
raise ParserError('Error parsing processes in {}: {}'
.format(filename, e.message))

0 comments on commit 742aad1

Please sign in to comment.