Bug 935596 : nsJARInputStream crashes debug builds when it encounters…

… a corrupt zip file. r=taras
Brli · Nov 7, 2013 · 4a3228a · 4a3228a
1 parent 124a03a
commit 4a3228a
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/modules/libjar/nsJARInputStream.cpp b/modules/libjar/nsJARInputStream.cpp
@@ -281,12 +281,8 @@ nsJARInputStream::ContinueInflate(char* aBuffer, uint32_t aCount,
         inflateEnd(&mZs);
 
         // stop returning valid data as soon as we know we have a bad CRC
-        if (mOutCrc != mInCrc) {
-            // asserting because while this rarely happens, you definitely
-            // want to catch it in debug builds!
-            NS_NOTREACHED(0);
+        if (mOutCrc != mInCrc)
             return NS_ERROR_FILE_CORRUPTED;
-        }
     }
 
     return NS_OK;