Skip to content

Commit

Permalink
Bug 1186787 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls…
Browse files Browse the repository at this point in the history
… in chrome/ with iterators. r=froydnj.
  • Loading branch information
nnethercote committed Nov 18, 2015
1 parent ad81103 commit 423ad1e
Showing 1 changed file with 9 additions and 21 deletions.
30 changes: 9 additions & 21 deletions chrome/nsChromeRegistryChrome.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -396,26 +396,6 @@ SerializeURI(nsIURI* aURI,
aURI->GetOriginCharset(aSerializedURI.charset);
}

static PLDHashOperator
EnumerateOverride(nsIURI* aURIKey,
nsIURI* aURI,
void* aArg)
{
nsTArray<OverrideMapping>* overrides =
static_cast<nsTArray<OverrideMapping>*>(aArg);

SerializedURI chromeURI, overrideURI;

SerializeURI(aURIKey, chromeURI);
SerializeURI(aURI, overrideURI);

OverrideMapping override = {
chromeURI, overrideURI
};
overrides->AppendElement(override);
return (PLDHashOperator)PL_DHASH_NEXT;
}

void
nsChromeRegistryChrome::SendRegisteredChrome(
mozilla::dom::PContentParent* aParent)
Expand Down Expand Up @@ -447,7 +427,15 @@ nsChromeRegistryChrome::SendRegisteredChrome(
rph->CollectSubstitutions(resources);
}

mOverrideTable.EnumerateRead(&EnumerateOverride, &overrides);
for (auto iter = mOverrideTable.Iter(); !iter.Done(); iter.Next()) {
SerializedURI chromeURI, overrideURI;

SerializeURI(iter.Key(), chromeURI);
SerializeURI(iter.UserData(), overrideURI);

OverrideMapping override = { chromeURI, overrideURI };
overrides.AppendElement(override);
}

if (aParent) {
bool success = aParent->SendRegisterChrome(packages, resources, overrides,
Expand Down

0 comments on commit 423ad1e

Please sign in to comment.