Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US139071: Lit 2 migration #157

Merged
merged 1 commit into from
May 26, 2022
Merged

US139071: Lit 2 migration #157

merged 1 commit into from
May 26, 2022

Conversation

gordon-plumb
Copy link
Contributor

@gordon-plumb gordon-plumb commented May 26, 2022

Need to migrate this repo to Lit 2 as well, since publish-fra depends on it.

@gordon-plumb gordon-plumb changed the title Lit 2 migration US139071: Lit 2 migration May 26, 2022
@gordon-plumb
Copy link
Contributor Author

Do we want to bump this to version 1.0.0? With content-components and other repos that were migrated to Lit 2, these changes were treated as a major version bump to prevent consumers from getting Lit 2 before they were ready. As far as I can tell, publish-fra is the only repo dependant on this repo, so the major version bump might not be necessary.

@MichaelKovalchuk
Copy link

Do we want to bump this to version 1.0.0? With content-components and other repos that were migrated to Lit 2, these changes were treated as a major version bump to prevent consumers from getting Lit 2 before they were ready. As far as I can tell, publish-fra is the only repo dependant on this repo, so the major version bump might not be necessary.

Sure. Lets bump it

@gordon-plumb gordon-plumb merged commit cd8dac2 into master May 26, 2022
@gordon-plumb gordon-plumb deleted the gplumb/lit-2 branch May 26, 2022 20:09
@ghost
Copy link

ghost commented May 26, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants