Add PluralRules locale data shimming #200
Conversation
| }; | ||
|
|
||
| function getCanonicalLocales(locales) { | ||
| const mappedLocales = [locales].flat().map(locale => { |
There was a problem hiding this comment.
This is only needed for Safari on older OS versions (< macOS ~12, based on sauce testing), which don't map the aliases back to mi.
| @@ -44,7 +44,6 @@ | |||
| "sinon": "^19.0.2" | |||
| }, | |||
| "dependencies": { | |||
| "@formatjs/intl-pluralrules": "^1", | |||
There was a problem hiding this comment.
Just to clarify: the other things that this polyfill was providing (the plural rules locale data for browsers who don't support the native API) aren't needed at all anymore?
There was a problem hiding this comment.
Ack! Safari 12 is the only browser that isn't blocked that doesn't support Intl.Pluralules. Do we want to keep it for that?
There was a problem hiding this comment.
In keeping it, we'd simply continue to include it but then override some of its behavior to support Māori?
There was a problem hiding this comment.
Discussed offline.
Brightspace loads... something in Safari 12 but it's completely unuseable so we're going ahead with removing the polyfill. We expect to block Safari 12 in the near future.
|
🎉 This PR is included in version 3.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Support for Māori across browsers is inconsistent at best. Specifically for
Intl.PluralRules(which is relied upon byformatjsto renderpluralarguments), no browsers have (proper) native support for Māori's plural categories. The@formatjs/intl-pluralrulespolyfill also does not have data for Māori, and provides no value otherwise asIntl.PluralRulesis well supported at this point.We can rely on native
Intl.PluralRulesas long as we can shim locale data into it forformatjsto use. So, that's what we do here.