Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MI-2736]: Done the review fixes of a github PR #636 #21

Merged
merged 8 commits into from
Feb 16, 2023
Merged

[MI-2736]: Done the review fixes of a github PR #636 #21

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bcd76b1
[MI-2736]: Review fixes done
Nityanand13 Feb 8, 2023
0d7bf31
Merge branch 'master' of github.com:mattermost/mattermost-plugin-gith…
Nityanand13 Feb 8, 2023
048321a
[MI-2736]: Review fixes done
Nityanand13 Feb 8, 2023
e5d8e63
Merge branch 'MM-618' of github.com:Brightscout/mattermost-plugin-git…
Nityanand13 Feb 8, 2023
5c8d8f7
[MI-2736]: Review fixes done
Nityanand13 Feb 9, 2023
211089f
[MI-2736]: Review fixes done
Nityanand13 Feb 10, 2023
d7b5adf
Merge branch 'MM-618' of github.com:Brightscout/mattermost-plugin-git…
Nityanand13 Feb 10, 2023
6429412
[MI-2736]: Review fixes done
Nityanand13 Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[MI-2736]: Review fixes done 
1. Improved code readability
  • Loading branch information
@Nityanand13
Nityanand13 committed Feb 8, 2023
commit bcd76b18263a8cea3295fee8dd04e582a86fcded
2 changes: 1 addition & 1 deletion server/plugin/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ func (p *Plugin) initializeAPI() {
apiRouter.HandleFunc("/closeorreopenissue", p.checkAuth(p.attachUserContext(p.closeOrReopenIssue), ResponseTypePlain)).Methods(http.MethodPost)
apiRouter.HandleFunc("/updateissue", p.checkAuth(p.attachUserContext(p.updateIssue), ResponseTypePlain)).Methods(http.MethodPost)
apiRouter.HandleFunc("/editissuemodal", p.checkAuth(p.attachUserContext(p.openIssueEditModal), ResponseTypePlain)).Methods(http.MethodPost)
apiRouter.HandleFunc("/closereopenissuemodal", p.checkAuth(p.attachUserContext(p.openCloseOrReopenIssueModal), ResponseTypePlain)).Methods(http.MethodPost)
apiRouter.HandleFunc("/close_reopen_issue_modal", p.checkAuth(p.attachUserContext(p.openCloseOrReopenIssueModal), ResponseTypePlain)).Methods(http.MethodPost)
apiRouter.HandleFunc("/attachcommentissuemodal", p.checkAuth(p.attachUserContext(p.openAttachCommentIssueModal), ResponseTypePlain)).Methods(http.MethodPost)
apiRouter.HandleFunc("/createissuecomment", p.checkAuth(p.attachUserContext(p.createIssueComment), ResponseTypePlain)).Methods(http.MethodPost)
manojmalik20 marked this conversation as resolved.
Show resolved Hide resolved
apiRouter.HandleFunc("/mentions", p.checkAuth(p.attachUserContext(p.getMentions), ResponseTypePlain)).Methods(http.MethodGet)
Expand Down
2 changes: 1 addition & 1 deletion webapp/src/client/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default class Client {
}

closeOrReopenIssueModal = async (payload) => {
return this.doPost(`${this.url}/closereopenissuemodal`, payload);
return this.doPost(`${this.url}/close_reopen_issue_modal`, payload);
}

attachCommentIssueModal = async (payload) => {
Expand Down