forked from mattermost/mattermost-plugin-github
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MI-2502]:Added custom type for webhook post in order to comment, edit and close issues #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Improved code quality 2. Made few contants
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
1. Changed few files to .tsx 2. Improved code quality
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/attach_comment_to_issue/attach_comment_to_issue.jsx
Outdated
Show resolved
Hide resolved
1. Improved code quality 2. Made a constant
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
1. Improved code readability
Kshitij-Katiyar
approved these changes
Jan 13, 2023
1. Made a package dor constants 2. Made a package for struct 3. Improved code redability
webapp/src/components/modals/close_reopen_issue/close_reopen_issue.tsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
1. Improved code quality 2. Fixed the issue that I was facing while creating issue or attaching a comment to the issue. 3. Changed few file names
1. Changed the names of few functions 2. Improved code quality
sooraj-shukla
suggested changes
Jan 23, 2023
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
1.Improved code readability
sooraj-shukla
approved these changes
Jan 24, 2023
1. Improved code readability
manojmalik20
approved these changes
Jan 27, 2023
1. Improved code quality
1. Improved code quality
manojmalik20
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.