Fix webpack graphql misresolution by renaming graphql.ts module (a…

…pollographql#8862)
BridgeAR · Sep 29, 2021 · becea12 · becea12
1 parent cbecc09
commit becea12
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,13 @@
+## Apollo Client 3.4.16 (not yet released)
+
+### Improvements
+
+- Prevent webpack from misresolving the `graphql` package as the local `@apollo/client/utilities/globals/graphql.js` module when `module.exports.resolve.preferRelative` is enabled in `webpack.config.js`.
+
+  > Note: if you encounter strange module resolution errors like `export 'isType' (imported as 'isType') was not found in 'graphql' (possible exports: removeTemporaryGlobals)` please try removing `preferRelative: true` from your `webpack.config.js` file, or find a way to disable that resolution behavior for packages within `node_modules`.
+
+  [@benjamn](https://github.com/benjamn) in [#8862](https://github.com/apollographql/apollo-client/pull/8862)
+
 ## Apollo Client 3.4.15
 
 ### Bug Fixes

diff --git a/src/utilities/globals/graphql.ts → src/utilities/globals/fix-graphql.ts b/src/utilities/globals/graphql.ts → src/utilities/globals/fix-graphql.ts
diff --git a/src/utilities/globals/index.ts b/src/utilities/globals/index.ts
@@ -10,7 +10,7 @@ export function checkDEV() {
 
 // Import graphql/jsutils/instanceOf safely, working around its unchecked usage
 // of process.env.NODE_ENV and https://github.com/graphql/graphql-js/pull/2894.
-import { removeTemporaryGlobals } from "./graphql";
+import { removeTemporaryGlobals } from "./fix-graphql";
 
 // Synchronously undo the global process.env.NODE_ENV polyfill that we created
 // temporarily while importing the offending graphql/jsutils/instanceOf module.