Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.1 #11

Closed
wants to merge 71 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
8188495
rust reimplementation working
cmatKhan Nov 23, 2024
003520a
optimization refactored
cmatKhan Nov 23, 2024
4461365
version 2.0.0 draft for release ready
cmatKhan Nov 28, 2024
fb93804
adjusting readme
cmatKhan Nov 28, 2024
5ec1a57
updating readme with links
cmatKhan Nov 28, 2024
179b238
updating changelog
cmatKhan Nov 28, 2024
f554122
updating headline
cmatKhan Nov 28, 2024
2d46221
adding build instructions
cmatKhan Nov 28, 2024
edd6bca
fixing a typo in readme
cmatKhan Nov 28, 2024
5c44bb1
adding .md to license
cmatKhan Nov 28, 2024
dbcceaa
removing license
cmatKhan Nov 28, 2024
dfd5fca
Create LICENSE
cmatKhan Nov 28, 2024
e4d0067
adding name to license
cmatKhan Nov 28, 2024
5b75653
adding pre-commit
cmatKhan Nov 30, 2024
3141497
adidng verbose to precommit
cmatKhan Nov 30, 2024
7c0dfe3
adjusting precommit
cmatKhan Nov 30, 2024
7f2ea90
linting with clippy
cmatKhan Nov 30, 2024
68050c0
continuing to lint with clippy
cmatKhan Nov 30, 2024
7461538
addressing clippy
cmatKhan Nov 30, 2024
8cc66ee
addressing clippy warnings
cmatKhan Nov 30, 2024
82b8d23
testing precommit
cmatKhan Nov 30, 2024
200bcea
still addressing clippy
cmatKhan Nov 30, 2024
f0e06b0
removing old main
cmatKhan Nov 30, 2024
35bd86c
testing CI
cmatKhan Nov 30, 2024
d741090
testing ci linting
cmatKhan Nov 30, 2024
7add022
fixing linting CI
cmatKhan Nov 30, 2024
6adc660
debugging linting ci
cmatKhan Nov 30, 2024
bdf5e71
adding a release CI
cmatKhan Nov 30, 2024
667f991
troubleshooting ci
cmatKhan Nov 30, 2024
916319e
debugging ci
cmatKhan Nov 30, 2024
587a065
debugging ci
cmatKhan Nov 30, 2024
29ee93f
debugging ci
cmatKhan Nov 30, 2024
43f795d
debugging ci
cmatKhan Nov 30, 2024
c1b84b5
debugging ci
cmatKhan Nov 30, 2024
94c69d7
debugging ci
cmatKhan Nov 30, 2024
6a3d456
adding gh token env var
cmatKhan Nov 30, 2024
c621eb3
debugging ci
cmatKhan Nov 30, 2024
cda0487
ci confirmed
cmatKhan Nov 30, 2024
39107fc
ready for pushing to dev
cmatKhan Nov 30, 2024
497c2bf
Merge pull request #1 from cmatKhan/rust_implementation
cmatKhan Nov 30, 2024
26f5690
revising readme installation instructions
cmatKhan Nov 30, 2024
87cd71b
Merge pull request #2 from cmatKhan/update_readme
cmatKhan Nov 30, 2024
2d2f36f
Update README.md
cmatKhan Nov 30, 2024
f42579b
Merge pull request #3 from BrentLab/cmatKhan-patch-1
cmatKhan Nov 30, 2024
eff7789
Update README.md
cmatKhan Nov 30, 2024
12c5f87
Merge pull request #4 from BrentLab/cmatKhan-patch-1
cmatKhan Nov 30, 2024
dec0619
adding status badges
cmatKhan Nov 30, 2024
fd166f6
Merge pull request #5 from BrentLab/cmatKhan-patch-1
cmatKhan Nov 30, 2024
75aa584
fixing threshold formula rendering
cmatKhan Dec 4, 2024
8f7e3e4
Merge pull request #6 from BrentLab/cmatKhan-patch-1
cmatKhan Dec 4, 2024
5ace98a
Update README.md
cmatKhan Dec 4, 2024
b92188c
Merge pull request #7 from BrentLab/cmatKhan-patch-1
cmatKhan Dec 4, 2024
38ecc79
changinasymptotic runtime println to eprintln
cmatKhan Dec 2, 2024
f6de002
fixing links in readme
cmatKhan Dec 4, 2024
a7f45f6
further refinements to the README
cmatKhan Dec 4, 2024
7618a51
Merge pull request #8 from cmatKhan/yeast_debugs
cmatKhan Dec 4, 2024
3226e0e
revising readme installation instructions
cmatKhan Nov 30, 2024
dc6551e
Update README.md
cmatKhan Nov 30, 2024
0c5de47
Update README.md
cmatKhan Nov 30, 2024
80711db
adding status badges
cmatKhan Nov 30, 2024
c46c8d0
fixing threshold formula rendering
cmatKhan Dec 4, 2024
5a6fe3e
Update README.md
cmatKhan Dec 4, 2024
d03258f
changinasymptotic runtime println to eprintln
cmatKhan Dec 2, 2024
5740ed7
fixing links in readme
cmatKhan Dec 4, 2024
8806b3a
further refinements to the README
cmatKhan Dec 4, 2024
dd0ddbd
Merge branch 'dev' of https://github.com/cmatKhan/Dual_Threshold_Opti…
cmatKhan Dec 4, 2024
5a7fc2a
Merge pull request #9 from cmatKhan/dev
cmatKhan Dec 4, 2024
315a65d
addressing linting
cmatKhan Dec 4, 2024
3255625
Merge branch 'dev' of https://github.com/BrentLab/Dual_Threshold_Opti…
cmatKhan Dec 4, 2024
61a6038
adding cachebusting to crates badge
cmatKhan Dec 4, 2024
5d11063
adding documentation link to library section of readme
cmatKhan Dec 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update README.md
  • Loading branch information
cmatKhan authored Nov 30, 2024
commit eff7789f2c213cb63f9cf1c621e538b6d9d258cd
64 changes: 25 additions & 39 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,23 @@ binary called `dual_threshold_optimization-macos-latest-default` from the releas
tab. There is also a windows executable, and both a default (non-mpi) and mpi version
for ubuntu (which will work on most linux OS).

You will need to
make this executable by entering
`chmod +x dual_threshold_optimization-macos-latest-default` in your terminal.
You will need to make this executable by entering

You may also want to rename the executable to something more manageable, eg
`mv dual_threshold_optimization-macos-latest-default dual_threshold_optimization` to
rename it to simply `dual_threshold_optimization`.
```bash
chmod +x dual_threshold_optimization-macos-latest-default
```

in your terminal. For windows, if you are not using the terminal, consult the internet
for the equivalent.

You may also want to rename the executable to something more manageable, eg from the
terminal

```bash
mv dual_threshold_optimization-macos-latest-default dual_threshold_optimization
```

to rename it to simply `dual_threshold_optimization`.


### Using the cmd line
Expand Down Expand Up @@ -139,7 +149,7 @@ dual_threshold_optimization -1 ranklist1.csv -2 ranklist2.csv -p 5 -t 1
```
This will output some run information to stderr, and a json to stdout. This is
important because it means that you can re-direct the stdout to a file
(see [output](#output))
(see below)

#### Output

Expand Down Expand Up @@ -212,12 +222,6 @@ At this point, you can run the tests with:
cargo test
```

or

```bash
cargo test
```

you can run the binary with

```bash
Expand All @@ -230,45 +234,27 @@ and you can guild with
cargo build
```

Note that there is a build profile for profiling which will build a release version
with the debug flags on:
Note that there is a build profile for time and memory performance profiling which will build
a release version with the debug flags on:

```bash
cargo build --profile release-debug
```

To build the binaries for each OS, use `cross`

```bash
cargo add cross
```

Then build like this

```bash
# linux
cross build --release --target x86_64-unknown-linux-gnu

# windows
cross build --release --target x86_64-pc-windows-gnu

# MacOS -- intel
cross build --release --target x86_64-apple-darwin

# MacOS -- apple silicon
cross build --release --target aarch64-apple-darwin
```

### Test data

Test data can be found in the `test_data` subdirectory
Minimal test data can be found in the `test_data` subdirectory

### Profiling
### Performance Profiling

I recommend profiling with [hyperfine](https://github.com/sharkdp/hyperfine)
for runtime and [heaptrack](https://github.com/KDE/heaptrack) for memory.
The results of profiling on the test data are in the `/profiling` subdirectory

### Pre-commit

Pre-commit is set up to run cargo fmt and clippy when you commit changes

## Algorithmic details

The following provides details on the DTO algorithm, step by step.
Expand Down
Loading