Pin GitHub Actions to commit SHAs for supply-chain hardening#78
Merged
Conversation
Tags (and, for pypa/gh-action-pypi-publish, a branch ref) are mutable and can be repointed without any change on our side. Pin every third-party uses: reference to a full commit SHA, keeping the original tag/branch as a trailing comment so Dependabot can still propose version bumps. Fixes #77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
Workflows referenced third-party actions by mutable tag, and
publish-pypi.yamlreferencedpypa/gh-action-pypi-publish@release/v1— a branch, not even a tag, which is more mutable still.What this does
Pins every third-party
uses:reference acrosslint-and-test.yaml,publish-pypi.yaml, andrelease.yamlto a full commit SHA, keeping the original tag/branch as a trailing comment (Dependabot reads this to propose future version bumps, once #75/#76 land).No behavior change — same versions, just pinned.
After merge
Enable
sha_pinning_requiredon the repo's Actions settings.How to verify
Trigger
lint-and-test.yaml(push/PR) and confirm it still passes with the pinned SHAs.Fixes #77