Skip to content

Compositing nodes #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 10, 2023
Merged

Compositing nodes #65

merged 21 commits into from
Sep 10, 2023

Conversation

BrendanParmer
Copy link
Owner

Features

  • Compositor Nodes!
    • New UI for Compositor Nodes
    • Full tree copying, input initialization, linking, etc
    • In add-on mode, Compositor Nodes copy over the current scene and recreate the node tree there
  • Utility functions for converting 1D and 2D vectors to Python strings

Fixes

  • Typo in Material menu bl_idname

Refactor
Cleaned up a lot of code in order to make adding compositing nodes as seamless and consistent as possible. Most notably,

  • Node settings now store the "type" of each setting (ST), so NTP no longer infers how it should be encoded in the generated code
  • Color ramp, curve mapping, images, and image user logic has been moved to be handled like other node settings
  • Introduced "special variables" which are hard set and should not be used for generated variable names, like for nodes, node trees, etc.

Style

  • Class name changes for consistency
  • Better type hinting for functions and some important variables
  • Better function descriptions
  • Nodes without settings are included in the settings dictionary

@BrendanParmer BrendanParmer added the enhancement New feature or request label Sep 3, 2023
@BrendanParmer BrendanParmer added this to the v3.0 milestone Sep 3, 2023
@BrendanParmer BrendanParmer self-assigned this Sep 3, 2023
This was linked to issues Sep 3, 2023
@BrendanParmer
Copy link
Owner Author

BrendanParmer commented Sep 3, 2023

TODO:

  • Some nodes can't find the settings to replicate, often when there is an asset missing
  • Hue correction curve is off

@BrendanParmer
Copy link
Owner Author

BrendanParmer commented Sep 10, 2023

  • Color Balance and Color Correction nodes aren't correct

@BrendanParmer BrendanParmer merged commit 6ce5cbb into main Sep 10, 2023
@BrendanParmer BrendanParmer deleted the compositing_nodes branch September 10, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

World, Line Style, and Light Material Nodes Compositing Nodes
1 participant