Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue with texture files with extensions specified in material defintion files not loading. #23

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

Lehm2000
Copy link
Contributor

This fixes a bug introduced with the addition of the dds texturing loading, where files defined in the material definition file that contained an extension would not load. Fix checks if the extension is already included in the texture path.

Copy link
Collaborator

@SamBoots SamBoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self, what if the .dds exists but the material file has it written down as texture.png.

Will test this out and maybe make an addition for when that happens.

Overall, good way to fix this and support older material files. Will accept after I did a check on .dds files when the material asks for a .png.

@Lehm2000
Copy link
Contributor Author

Lehm2000 commented Jun 3, 2024

Note to self, what if the .dds exists but the material file has it written down as texture.png.

Will test this out and maybe make an addition for when that happens.

Overall, good way to fix this and support older material files. Will accept after I did a check on .dds files when the material asks for a .png.

I actually thought about that scenario. But I figured if someone is going through the trouble of authoring dds files they would update the material files as well. So I figured that issue should be fixed on the content side. If you feel different I can look at it again.

@SamBoots
Copy link
Collaborator

SamBoots commented Jun 5, 2024

Good way to handle this if the .png doesn't exist look for the .dds file and vice versa I think, I'll implement that when I test out this cl.

Copy link
Collaborator

@SamBoots SamBoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple addition added that when it looks for a dds texture it will also check if in the material it started with a .png

@SamBoots SamBoots merged commit 5960cde into BredaUniversityGames:main Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants