Adds proper OpenCV seeking#163
Merged
Breakthrough merged 1 commit intoBreakthrough:masterfrom Aug 6, 2020
obroomhall:master
Merged
Adds proper OpenCV seeking#163Breakthrough merged 1 commit intoBreakthrough:masterfrom obroomhall:master
Breakthrough merged 1 commit intoBreakthrough:masterfrom
obroomhall:master
Conversation
Breakthrough
approved these changes
Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code adds real seeking, rather than looping over grab. This should speed up seeking in large files significantly.
However, the final grab at the end of the method should also be removed, only reason I left it in was because PySceneDetect's grab function seems to be doing something under the hood that I couldn't figure out to do with start_time or _curr_time. So someone with more exposure to this code should take a quick look to remove it.