Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: update keep matlab flag to work as documentation indicates #83

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

ahurli
Copy link
Contributor

@ahurli ahurli commented Nov 9, 2020

Purpose

Fix the default behavior of the keep-matlab flag to match the documentation.

What is the code doing?

Currently if the --keep-matlab flag is used, the matlab files will be deleted and the default is to keep them. Switching this line will switch the default behavior so that these files are only kept if the flag is used.

Where to Look

The code changed is in extract_data.py.

Time to Review

5 min.

@danielolsen
Copy link
Contributor

Previously, after parsing the args with the flag not set:
Namespace(end_date=None, execute_dir=None, frequency='H', keep_matlab=True, matlab_dir=None, output_dir=None, scenario_id='1601', start_date=None)
With the latest code:
Namespace(end_date=None, execute_dir=None, frequency='H', keep_matlab=False, matlab_dir=None, output_dir=None, scenario_id='1601', start_date=None)
And the behavior works as expected.

Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@ahurli ahurli merged commit 49fbebf into develop Nov 9, 2020
@ahurli ahurli deleted the anna/extract-data-bug branch January 27, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants