Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action to check formatting #68

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Add github action to check formatting #68

merged 2 commits into from
Jul 24, 2020

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Jul 24, 2020

What the code does

First commit defines the action, which installs black and runs the check on only the pyreisejl folder, outputting the diff if it fails. I used this instead of the action provided by black repo since that one doesn't enable specifying the directory (would work either way, just felt this was more explicit).
Second commit is the result of running black locally so the check will pass.

Note: as we add more workflows to CI, this will probably be simplified by calling tox and moving the workflow logic to a tox.ini so we can run the same command locally and in a github action (rather than call several separate things - black, pytest, isort, etc). Wanted to share the idea but this note can be ignored for now.

Time to review

5 mins, probably

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usual simple quote to double quote

@danielolsen danielolsen self-requested a review July 24, 2020 21:24
@jenhagg jenhagg merged commit d2fea40 into develop Jul 24, 2020
@jenhagg jenhagg deleted the jon/black branch July 24, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants