Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify all parameters for DemandFlexibility struct #131

Merged
merged 1 commit into from
May 7, 2021

Conversation

lanesmith
Copy link
Collaborator

Purpose

The purpose of this code is to fix the error discussed in #129. When a demand_flexibility.csv file is not available, not all of the parameters of the DemandFlexibility struct were defined.

What is the code doing?

In the try/catch loop that is responsible for trying to load the demand_flexibility.csv file in read_demand_flexibility, the three parameters that were previously unspecified are now specified.

Where to look

The fix lives in the read_demand_flexibility function in src/read.jl.

Testing

I tested the fix on my local machine and the error presented in #129 no longer occurs. As @BainanXia mentioned, the demand flexibility functionality is not yet integrated into PowerSimData, so I cannot be sure that there are not any errors on that end. I also have not tested this with plug, which is where the error was first noted. However, based on the error reported in #129, I believe this fix should do the trick.

Time estimate

This review should be pretty quick.

@lanesmith lanesmith added the bug Something isn't working label May 7, 2021
@lanesmith lanesmith self-assigned this May 7, 2021
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe @jon-hagg could give a quick try.

Copy link
Collaborator

@jenhagg jenhagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@lanesmith
Copy link
Collaborator Author

Great, I'll merge it in!

@jenhagg jenhagg linked an issue May 7, 2021 that may be closed by this pull request
@lanesmith lanesmith merged commit 6d44123 into develop May 7, 2021
@lanesmith lanesmith deleted the lane/param_fix branch May 7, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when launching a simulation in container
3 participants