Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set bus_id index name #709

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: set bus_id index name #709

merged 1 commit into from
Dec 7, 2022

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Dec 7, 2022

Purpose

Fix error when we add buses, e.g. via the demo_western.py script in plug. Without the index name, the grid.pkl used in call.py cannot be exported to csv. This should address the issue from the community slack.

What the code is doing

Add the index name for bus data frame. We already had this for the other ones but since it was tested with the demo_texas script, which doesn't transform buses, the error didn't occur.

Testing

Ran a simulation using the western demo and didn't have the error anymore.

Time estimate

2 min

@jenhagg jenhagg self-assigned this Dec 7, 2022
@jenhagg jenhagg requested a review from rouille December 7, 2022 21:56
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@jenhagg jenhagg merged commit 74422ce into develop Dec 7, 2022
@jenhagg jenhagg deleted the jen/index branch December 7, 2022 22:08
@jenhagg jenhagg mentioned this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants