Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipenv lock file #698

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Update pipenv lock file #698

merged 3 commits into from
Nov 2, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Nov 2, 2022

Pull Request doc

Purpose

Update Pipfile.lock file and fix error and warnings raised by new version of pandas

What the code is doing

N/A

Testing

Existing unit tests

Where to look

  • handle a FutureWarning raised by pandas (FutureWarning: The default value of numeric_only in DataFrameGroupBy.mean is deprecated. In a future version, numeric_only will default to False. Either specify numeric_only or select only columns which should be valid for the function) in the investment_costs module
  • Use list in place of set in the mock_profile_input module. That was generating several an error in several tests.

Usage Example/Visuals

N/A

Time estimate

5min

@rouille rouille added the dependencies Pull requests that update a dependency file label Nov 2, 2022
@rouille rouille self-assigned this Nov 2, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rouille rouille merged commit f11f64c into develop Nov 2, 2022
@rouille rouille deleted the ben/dependencies branch November 2, 2022 21:07
@jenhagg jenhagg mentioned this pull request Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants