Enable roundtrip conversion PyPSA Network <--> PowerSimData Grid objects

[rouille]

Pull Request doc

Purpose

Test grid equality for round trip conversion Grid -> Network -> Grid.

What the code is doing

• Define __class__ property so FromPyPSA instances have type Grid
• Check grid equality and generate some prints

Testing

Tests are failing due to differences in the two grids in the test_import_exported_network. This is illustrated when running pytest powersimdata/input/converter/tests/test_pypsa_to_grid.py:

        print("Compare bus values for common columns")
>       assert_frame_equal(ref.bus[ref.bus.columns], test.bus[ref.bus.columns])
E       AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="type") are different
E       
E       Attribute "dtype" are different
E       [left]:  int64
E       [right]: object

And:

Difference in bus columns
Index(['type', 'Pd', 'Qd', 'Gs', 'Bs', 'zone_id', 'Vm', 'Va', 'baseKV',
       'loss_zone', 'Vmax', 'Vmin', 'lam_P', 'lam_Q', 'mu_Vmax', 'mu_Vmin',
       'interconnect', 'lat', 'lon'],
      dtype='object')
Index(['bus_id', 'type', 'Pd', 'Qd', 'Gs', 'Bs', 'zone_id', 'Vm', 'Va',
       'baseKV', 'loss_zone', 'Vmax', 'Vmin', 'lam_P', 'lam_Q', 'mu_Vmax',
       'mu_Vmin', 'interconnect', 'lat', 'lon', 'includes_pypsa_shunt'],
      dtype='object')
Difference in branch columns
Index(['from_bus_id', 'to_bus_id', 'r', 'x', 'b', 'rateA', 'rateB', 'rateC',
       'ratio', 'angle', 'status', 'angmin', 'angmax', 'Pf', 'Qf', 'Pt', 'Qt',
       'mu_Sf', 'mu_St', 'mu_angmin', 'mu_angmax', 'branch_device_type',
       'interconnect', 'from_zone_id', 'to_zone_id', 'from_zone_name',
       'to_zone_name', 'from_lat', 'from_lon', 'to_lat', 'to_lon'],
      dtype='object')
Index(['from_bus_id', 'to_bus_id', 'r', 'x', 'b', 'rateA', 'rateB', 'rateC',
       'ratio', 'angle', 'status', 'angmin', 'angmax', 'Pf', 'Qf', 'Pt', 'Qt',
       'mu_Sf', 'mu_St', 'mu_angmin', 'mu_angmax', 'branch_device_type',
       'interconnect', 'from_zone_id', 'to_zone_id', 'from_zone_name',
       'to_zone_name', 'from_lat', 'from_lon', 'to_lat', 'to_lon',
       'branch_device_type', 'branch_device_type', 'branch_device_type'],
      dtype='object')

There are likely other issues in the converter(s).

Where to look

N/A

Usage Example/Visuals

N/A

Time estimate

N/A

[rouille]

@FabianHofmann, this could help testing grid equality

[rouille]

The roundtrip conversion has been fixed after merging #678.

[rouille]

@FabianHofmann, I added storage devices to the reference grid and the test (grid equality after roundtrip conversion) is failing.

[FabianHofmann]

@rouille thanks for the update, I'll fix that asap

[rouille]

@rouille thanks for the update, I'll fix that asap

Thanks. The round trip conversion including storage has been fixed after merging #685. @bainan and @jenhagg, this is now ready for full review

[BainanXia]

This looks good. I left a couple of comments that might out of the scope of this PR. Also, as discussed elsewhere, we will refactor the grid equality definition here to incorporate grid comparisons to different extents as we do in the tests here.

[BainanXia]

We will need to refactor the p_nom assignment after the implementation of "subsystem" logic for hydro/PHS.

[rouille]

Ah. It might be even more complicated. @FabianHofmann, will we need to add hydro and PHS generators located in the plant data frame of the Grid object to the StorageUnit component of the Network object? Or they will simply be added to the Generator component?

[FabianHofmann]

That is a good question, I'd prefer to add them to StorageUnit (assuming this is where they originally come from). But I prefer to tackle that in a separate PR.

[rouille]

Sounds good.