Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf improvements for tests and minor fixes #673

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Perf improvements for tests and minor fixes #673

merged 5 commits into from
Sep 2, 2022

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Sep 1, 2022 •
edited
Loading

Purpose

Reduce test duration by reusing objects that don't really need to be recreated.

What the code is doing

  • Create fewer instances of OutputData, InputData, and ProfileInput.
  • Use texas grid for demand flexibility test instead of usa
  • use None as default argument
  • skip test that downloads from zenodo

Testing

Running the tests locally shows a small but not totally insignificant reduction in test duration.

Time estimate

2 min

rouille
rouille approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can only help

@jenhagg jenhagg changed the title perf: reduce unnecessary object creation Perf improvements for tests and minor fixes Sep 1, 2022
@jenhagg jenhagg self-assigned this Sep 2, 2022
@jenhagg jenhagg merged commit 0851f60 into develop Sep 2, 2022
@jenhagg jenhagg deleted the jen/tests branch September 2, 2022 01:17
@jenhagg jenhagg mentioned this pull request Dec 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouille rouille rouille approved these changes

@BainanXia BainanXia Awaiting requested review from BainanXia

Assignees

@jenhagg jenhagg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenhagg @rouille @BainanXia