Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for plotting function plot_bar_shortfall #362

Merged
merged 2 commits into from
Aug 27, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Aug 26, 2022

Pull Request doc

Purpose

Improve test coverage of the plot_bar_shortfall function. The docstring of the function is formatted. Closes #361.

What the code is doing

N/A

Testing

Add new tests to hit missing statements. More specifically, the function is called with new sets of the areas parameter.
Before:

Name                                                                     Stmts   Miss Branch BrPart  Cover
----------------------------------------------------------------------------------------------------------
postreise/plot/plot_bar_shortfall.py                                        89     16     48      9    80%

After:

Name                                                                     Stmts   Miss Branch BrPart  Cover
----------------------------------------------------------------------------------------------------------
postreise/plot/plot_bar_shortfall.py                                        89      5     48      5    93%

Where to look

The test_plot_bar_shortfall module.

Usage Example/Visuals

N/A

Time estimate

2min

@rouille rouille added the good first issue Good for newcomers label Aug 26, 2022
@rouille rouille self-assigned this Aug 26, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rouille rouille changed the title Improve test coverage for plotting function plot_bar_shortfall Improve test coverage for plotting function plot_bar_shortfall Aug 27, 2022
@rouille rouille merged commit 8333588 into develop Aug 27, 2022
@rouille rouille deleted the ben/shortfall branch August 27, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage of plot_bar_shortfall
2 participants