Fix typo in argument to workflow trigger #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We should trigger a docker build of the
postreise:stableimage when we publish a new release to PyPI. However, this will not work if the input argument is not spelled correctly. The workflow doesn't explicitly fail, but it does emit the following error message.What the code is doing
Change the argument name to match the workflow being run - see https://github.com/Breakthrough-Energy/plug/blob/main/.github/workflows/docker-build.yml#L6
Testing
I believe this was tested when I added the parameterization here Breakthrough-Energy/actions#8, but that didn't stop typos from occurring. Not sure how to test unless we do another release, but we can run the docker build workflow manually, so it's not an issue.
Time estimate
1 min