remove isTbcOnly from profile#394
remove isTbcOnly from profile#394Alessandro-Barbieri wants to merge 18 commits intoBreakBB:masterfrom
Conversation
|
not tested yet, am I going into the right direction? |
add draenei passive to ranged hit calculation
add vscode folder to gitignore
fix annotations
replace deprecated functions
|
@Alessandro-Barbieri you change a lot of stats to be visible across various expansions. Is that intended? Examples are Armor Pen (visible in every expansion with this PR) and Haste (visible in TBC and WotLK). |
it's intentional:
|
| category.expertiseRating, category.hasteRating, category.hasteBonus) | ||
| else | ||
| if ECS.IsClassic then | ||
| _CreateStatInfo(category, category.attackPower, category.crit) |
There was a problem hiding this comment.
Since more values should be shown now, this needs to actually render them. A reminder IsClassic means Era, HC and SoD.
There was a problem hiding this comment.
I need to rebase this PR on top of #404 first
Co-authored-by: Björn Heiß <b.boeing@online.de>
2 participants
removed
isTbcOnlyswapped the logic on many expansion checks