Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when talk to NPCs that are not coded. #1

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Fix crash when talk to NPCs that are not coded. #1

merged 1 commit into from
Nov 11, 2021

Conversation

KenZync
Copy link
Contributor

@KenZync KenZync commented Nov 6, 2021

No description provided.

@KOOKIIEStudios
Copy link
Collaborator

git blame: This change was made by Brandon during a refactor: ebfe797.

LGTM :shipit:
Makes sense, since the client uses pounds (#) to denote formatting options in NPC text (e.g. #k for black text) - an un-escaped pound symbol would likely result in crashes. I assume that you've already tested it prior to PR.

Will merge, since the ElectronMS does not have a #suggestions channel, so that phrase was redundant anyway.

@KOOKIIEStudios KOOKIIEStudios merged commit 307cd82 into Bratah123:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants