Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cordova #599

Merged
merged 17 commits into from
Oct 16, 2019
Merged

Update Cordova #599

merged 17 commits into from
Oct 16, 2019

Conversation

echo-branch
Copy link
Contributor

This is a major update.

Update iOS SDK to 0.29.1
Update Android SDK to 4.1.0
Switch to Cocoapods
Switch to Maven
Add CPID and LATD methods

Known issues:
iOS command line build fails due to switch to cocoapods.
apache/cordova-ios#659

CPID and LATD methods do not work on Android.

Copy link
Contributor

@bklastaitis-branch bklastaitis-branch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have the full context/understanding of this project but left comments in a couple places that I did understand.

CHANGELOG.md Outdated Show resolved Hide resolved
src/android/io/branch/BranchSDK.java Show resolved Hide resolved
src/android/io/branch/BranchSDK.java Outdated Show resolved Hide resolved
Copy link
Contributor

@bklastaitis-branch bklastaitis-branch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@echo-branch echo-branch merged commit 354d023 into master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants