Skip to content

Chore/refactored vector stores #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 6, 2023

Conversation

jaigouk
Copy link
Contributor

@jaigouk jaigouk commented Jun 6, 2023

Changes

  • fix hnswlib based search and add specs
  • add multiple call contexts for other types
  • when building vector strore from array, there can be differenct structures. make it consistent and add documents
  • remove @errors from vector_store/pgvector/save_to_database.rb
  • add more examples in notebooks/vector_search_examples.ipynb
  • resolve Readme vector search example 404 #86

Why?

  • when building vector store with ruby array, it should be simple and yet we need to be consistent with :in_memory and :pgvector
  • in specs, we should avoid stubbing Boxcars::VectorStore::EmbedViaOpenAI.call

Testing

specs are green and checked with irb -r dotenv/load -r ./lib/boxcars
Screenshot 2023-06-07 at 00 25 02

Copy link
Contributor

@francis francis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francis francis merged commit f94bdab into BoxcarsAI:main Jun 6, 2023
@jaigouk jaigouk mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme vector search example 404
2 participants